From: Doug Anderson <dianders@chromium.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Gwendal Grignou <gwendal@chromium.org>, Chao Yu <chao@kernel.org>,
Ryo Hashimoto <hashimoto@chromium.org>,
Vadim Sukhomlinov <sukhomlinov@google.com>,
Guenter Roeck <groeck@chromium.org>,
apronin@chromium.org, linux-doc@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
Jonathan Corbet <corbet@lwn.net>,
LKML <linux-kernel@vger.kernel.org>,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH] Revert "ext4 crypto: fix to check feature status before get policy"
Date: Wed, 30 Oct 2019 14:59:03 -0700 [thread overview]
Message-ID: <CAD=FV=X6Q3QZaND-tfYr9mf-KYMeKFmJDca3ee-i9roWj+GHsQ@mail.gmail.com> (raw)
In-Reply-To: <20191030205745.GA216218@sol.localdomain>
Hi,
On Wed, Oct 30, 2019 at 1:57 PM Eric Biggers <ebiggers@kernel.org> wrote:
>
> FWIW, from reading the Chrome OS code, I think the code you linked to isn't
> where the breakage actually is. I think it's actually at
> https://chromium.googlesource.com/chromiumos/platform2/+/refs/heads/master/chromeos-common-script/share/chromeos-common.sh#375
> ... where an init script is using the error message printed by 'e4crypt
> get_policy' to decide whether to add -O encrypt to the filesystem or not.
>
> It really should check instead:
>
> [ -e /sys/fs/ext4/features/encryption ]
OK, I filed <https://crbug.com/1019939> and CCed all the people listed
in the cryptohome "OWNERS" file. Hopefully one of them can pick this
up as a general cleanup. Thanks!
-Doug
next prev parent reply other threads:[~2019-10-30 22:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 17:06 [PATCH] Revert "ext4 crypto: fix to check feature status before get policy" Douglas Anderson
2019-10-30 17:37 ` Eric Biggers
2019-10-30 17:51 ` Doug Anderson
2019-10-30 19:02 ` Eric Biggers
2019-10-30 20:57 ` Eric Biggers
2019-10-30 21:59 ` Doug Anderson [this message]
2019-10-31 17:52 ` Doug Anderson
2019-11-01 4:36 ` Eric Biggers
2019-11-01 13:32 ` Guenter Roeck
2019-11-01 18:17 ` Guenter Roeck
2019-11-02 22:10 ` Guenter Roeck
2019-11-03 13:19 ` Theodore Y. Ts'o
2019-11-04 7:45 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=X6Q3QZaND-tfYr9mf-KYMeKFmJDca3ee-i9roWj+GHsQ@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=adilger.kernel@dilger.ca \
--cc=apronin@chromium.org \
--cc=chao@kernel.org \
--cc=corbet@lwn.net \
--cc=ebiggers@kernel.org \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=hashimoto@chromium.org \
--cc=jaegeuk@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sukhomlinov@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).