From: Doug Anderson <dianders@chromium.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Brian Norris <briannorris@chromium.org>,
Thierry Reding <thierry.reding@gmail.com>,
Olof Johansson <olof@lixom.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Brian Norris <computersforpeace@gmail.com>,
linux-pwm <linux-pwm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Stephen Barber <smbarber@chromium.org>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo <enric.balletbo@collabora.co.uk>,
Randall Spangler <rspangler@chromium.org>,
Shawn Nematbakhsh <shawnn@chromium.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Todd Broch <tbroch@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>
Subject: Re: [PATCH v2 2/4] mfd: cros_ec: add EC_PWM function definitions
Date: Thu, 16 Jun 2016 08:51:45 -0700 [thread overview]
Message-ID: <CAD=FV=X8eOQLbdAseL2_JwpOFNjSLDAi9hX=NrE=CfrrTZfAmA@mail.gmail.com> (raw)
In-Reply-To: <20160616153817.GD21702@dell>
Lee,
On Thu, Jun 16, 2016 at 8:38 AM, Lee Jones <lee.jones@linaro.org> wrote:
> On Thu, 02 Jun 2016, Brian Norris wrote:
>
>> The EC_CMD_PWM_{GET,SET}_DUTY commands allow us to control a PWM that is
>> attached to the EC, rather than the main host SoC. The API provides
>> functionality-based (e.g., keyboard light, backlight) or index-based
>> addressing of the PWM(s). Duty cycles are represented by a 16-bit value,
>> where 0 maps to 0% duty cycle and U16_MAX maps to 100%. The period
>> cannot be controlled.
>>
>> This command set is more generic than, e.g.,
>> EC_CMD_PWM_{GET,SET}_KEYBOARD_BACKLIGHT and could possibly used to
>> replace it on future products.
>>
>> Let's update the command header to include the definitions.
>>
>> Signed-off-by: Brian Norris <briannorris@chromium.org>
>> ---
>> v2: no change
>>
>> include/linux/mfd/cros_ec_commands.h | 31 +++++++++++++++++++++++++++++++
>> 1 file changed, 31 insertions(+)
>>
>> diff --git a/include/linux/mfd/cros_ec_commands.h b/include/linux/mfd/cros_ec_commands.h
>> index 13b630c10d4c..d673575e0ada 100644
>> --- a/include/linux/mfd/cros_ec_commands.h
>> +++ b/include/linux/mfd/cros_ec_commands.h
>> @@ -949,6 +949,37 @@ struct ec_params_pwm_set_fan_duty {
>> uint32_t percent;
>> } __packed;
>>
>> +#define EC_CMD_PWM_SET_DUTY 0x25
>> +/* 16 bit duty cycle, 65535 = 100% */
>> +#define EC_PWM_MAX_DUTY 65535
>
> Any reason this isn't represented in hex, like we do normally?
>
>> +enum ec_pwm_type {
>> + /* All types, indexed by board-specific enum pwm_channel */
>> + EC_PWM_TYPE_GENERIC = 0,
>> + /* Keyboard backlight */
>> + EC_PWM_TYPE_KB_LIGHT,
>> + /* Display backlight */
>> + EC_PWM_TYPE_DISPLAY_LIGHT,
>> + EC_PWM_TYPE_COUNT,
>> +};
>
> Are these comments really necessary? I'd recommend that if your
> defines require comments, then they are not adequately named. In this
> case however, I'd suggest that they are and the comments are
> superfluous.
>
>> +struct ec_params_pwm_set_duty {
>> + uint16_t duty; /* Duty cycle, EC_PWM_MAX_DUTY = 100% */
>> + uint8_t pwm_type; /* ec_pwm_type */
>> + uint8_t index; /* Type-specific index, or 0 if unique */
>> +} __packed;
>
> Please use kerneldoc format.
>
>> +#define EC_CMD_PWM_GET_DUTY 0x26
>> +
>> +struct ec_params_pwm_get_duty {
>> + uint8_t pwm_type; /* ec_pwm_type */
>> + uint8_t index; /* Type-specific index, or 0 if unique */
>> +} __packed;
Probably the reason for all of these non-kernel-isms is that this
isn't a kernel file. From the top of the file:
* NOTE: This file is copied verbatim from the ChromeOS EC Open Source
* project in an attempt to make future updates easy to make.
So the source of truth for this file is
<https://chromium.googlesource.com/chromiumos/platform/ec/+/master/include/ec_commands.h>.
Someone could probably submit a CL to that project to make it a little
more kernel-ish and then we'd have to see if the EC team would accept
such changes...
-Doug
next prev parent reply other threads:[~2016-06-16 15:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 1:21 [PATCH v2 0/4] pwm: add support for ChromeOS EC PWM Brian Norris
2016-06-03 1:21 ` [PATCH v2 1/4] mfd: cros_ec: Add cros_ec_cmd_xfer_status helper Brian Norris
2016-06-16 15:30 ` Lee Jones
2016-06-16 15:38 ` Enric Balletbo i Serra
2016-06-03 1:21 ` [PATCH v2 2/4] mfd: cros_ec: add EC_PWM function definitions Brian Norris
2016-06-16 15:38 ` Lee Jones
2016-06-16 15:51 ` Doug Anderson [this message]
2016-06-17 8:06 ` Lee Jones
2016-06-17 15:28 ` Doug Anderson
2016-06-20 8:00 ` Lee Jones
2016-06-20 17:56 ` Brian Norris
2016-06-17 15:55 ` Thierry Reding
2016-06-17 19:13 ` Brian Norris
2016-06-17 19:21 ` Brian Norris
2016-06-20 7:47 ` Lee Jones
2016-06-03 1:21 ` [PATCH v2 3/4] doc: dt: pwm: add binding for ChromeOS EC PWM Brian Norris
2016-06-06 13:36 ` Rob Herring
2016-06-03 1:21 ` [PATCH v2 4/4] pwm: add ChromeOS EC PWM driver Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=X8eOQLbdAseL2_JwpOFNjSLDAi9hX=NrE=CfrrTZfAmA@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=bleung@chromium.org \
--cc=boris.brezillon@free-electrons.com \
--cc=briannorris@chromium.org \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=enric.balletbo@collabora.co.uk \
--cc=gwendal@chromium.org \
--cc=javier@osg.samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rspangler@chromium.org \
--cc=shawnn@chromium.org \
--cc=smbarber@chromium.org \
--cc=tbroch@chromium.org \
--cc=thierry.reding@gmail.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).