From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60D35C432BE for ; Fri, 23 Jul 2021 23:06:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4341960EB5 for ; Fri, 23 Jul 2021 23:06:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233151AbhGWWZ1 (ORCPT ); Fri, 23 Jul 2021 18:25:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232904AbhGWWZ0 (ORCPT ); Fri, 23 Jul 2021 18:25:26 -0400 Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2006BC061575 for ; Fri, 23 Jul 2021 16:05:58 -0700 (PDT) Received: by mail-qt1-x836.google.com with SMTP id w10so2762030qtj.3 for ; Fri, 23 Jul 2021 16:05:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TXXHRlqkn1UKOJrEoCU/1CKsPV1IVFDrHXzP0rexpUc=; b=kVhKTV2jwfU3UL2TDVAx6Od2VUtF8PD0tgQKJyramFzwij7jMAQUysiBLabG1p2Llz Ep8C6gJX7kRzIEA1Nu3ClCym8TQf+DSjQflhNSgcme7OBA0D1izAakUn+2PFJbgt5Q4I IujYcYZTx1uXzWQVUaqC5JLKexzzgMlgzil4k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TXXHRlqkn1UKOJrEoCU/1CKsPV1IVFDrHXzP0rexpUc=; b=l3BnRJpUC8MCGaDT3oh47TQbiqiy5v3oeu34dq5z8hNIgM3YRZeKouXvQOZLHJw2w0 Q/fQef99uEOUb6NfEr+bWP9Cz+vUbklWaUa8EDLfsiyHd7YnUZk54gm4VVEjxw6SldbO xaBvVtO/0ck1yQ50ak1VFDBdV7Mdu86vu7Dl+p45S7dKnh/u+avOijYYaehqyUmIeKqN Jz2jp1vEl1a7HI1mWY1oDz+AJJMc7tm+ZtQcRMPNIIT9TpZYlTk5B0flsET8A4ORPA8g IctDO3XMaOQm6EQg+GAapMRuUwvP+1gsSSnnBxkhacSZga8Epl4jZtyTr28zytayNlIC zeBw== X-Gm-Message-State: AOAM532vhX94a2FNdZPtrTdPvBfRILuzETWjD5w2c0POdfEKBRS2e5Vw FQDaV4YQ+8Jlh245ZvayTTsnmrShKLhM/A== X-Google-Smtp-Source: ABdhPJyLKo/CY+UETc1NR7hGcrKHh8O+OF/4EvoCOktzsJySrCnmlTy8fLxCB12gUSZ/pyukYr/j3A== X-Received: by 2002:ac8:665a:: with SMTP id j26mr6066373qtp.254.1627081557215; Fri, 23 Jul 2021 16:05:57 -0700 (PDT) Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com. [209.85.219.173]) by smtp.gmail.com with ESMTPSA id g1sm2884022qkd.89.2021.07.23.16.05.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jul 2021 16:05:56 -0700 (PDT) Received: by mail-yb1-f173.google.com with SMTP id g76so4717115ybf.4 for ; Fri, 23 Jul 2021 16:05:56 -0700 (PDT) X-Received: by 2002:a25:6088:: with SMTP id u130mr9735827ybb.257.1627081555988; Fri, 23 Jul 2021 16:05:55 -0700 (PDT) MIME-Version: 1.0 References: <20210521134437.v2.1.Id1c70158722750aec0673d60c12e46a9c66bbfed@changeid> In-Reply-To: <20210521134437.v2.1.Id1c70158722750aec0673d60c12e46a9c66bbfed@changeid> From: Doug Anderson Date: Fri, 23 Jul 2021 16:05:44 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] PM: AVS: qcom-cpr: Use nvmem_cell_read_variable_le_u32() To: "Rafael J . Wysocki" Cc: Bjorn Andersson , Niklas Cassel , Akhil P Oommen , linux-arm-msm , Ulf Hansson , Andy Gross , Niklas Cassel , LKML , Linux PM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rafael / Bjorn, On Fri, May 21, 2021 at 1:45 PM Douglas Anderson wrote: > > Let's delete the private function cpr_read_efuse() since it does the > basically the same thing as the new API call > nvmem_cell_read_variable_le_u32(). > > Differences between the new API call and the old private function: > * less error printing (I assume this is OK). > * will give an error if the value doesn't fit in 32-bits (the old code > would have truncated silently). > > Signed-off-by: Douglas Anderson > --- > I haven't done any more than compile-test this. Mostly I'm just > writing this patch because it helped provide inspiration for the > general API function. > > Changes in v2: > - Resending v1 as a singleton patch; dependency is merged in mainline. > > drivers/soc/qcom/cpr.c | 43 +++++------------------------------------- > 1 file changed, 5 insertions(+), 38 deletions(-) Are either of you interested in landing this? I guess Rafael landed most of the recent changes to this driver, but it used to be under the 'power' directory. Now that it's under 'drivers/soc/qcom' maybe it should go through Bjorn's tree? -Doug