From: Doug Anderson <dianders@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Wolfram Sang <wsa@the-dreams.de>,
LKML <linux-kernel@vger.kernel.org>,
linux-i2c@vger.kernel.org,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Karthikeyan Ramasubramanian <kramasub@codeaurora.org>,
Sagar Dharia <sdharia@codeaurora.org>,
Girish Mahadevan <girishm@codeaurora.org>
Subject: Re: [PATCH v3 2/3] i2c: i2c-qcom-geni: Simplify tx/rx functions
Date: Tue, 25 Sep 2018 14:49:34 -0700 [thread overview]
Message-ID: <CAD=FV=X9yDF95NvuJGFMWJHBFS87VG4jJP946oH6w8gB3LGRvQ@mail.gmail.com> (raw)
In-Reply-To: <20180924235235.182649-2-swboyd@chromium.org>
Hi,
On Mon, Sep 24, 2018 at 4:52 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> We never really look at the 'ret' local variable in these functions, so
> let's remove it to make way for shorter and simpler code. Furthermore,
> we can shorten some lines by adding two local variables for the SE and
> the message length so that everything fits in 80 columns and testing the
> 'dma_buf' local variable in lieu of the 'mode' local variable. And
> kernel style is to leave the return statement by itself, detached from
> the rest of the function.
>
> Cc: Karthikeyan Ramasubramanian <kramasub@codeaurora.org>
> Cc: Sagar Dharia <sdharia@codeaurora.org>
> Cc: Girish Mahadevan <girishm@codeaurora.org>
> Cc: Doug Anderson <dianders@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
> drivers/i2c/busses/i2c-qcom-geni.c | 79 ++++++++++++++----------------
> 1 file changed, 36 insertions(+), 43 deletions(-)
It's so polished I can see my reflection in it now. Looks like this
snuck in a few other cleanups compared to v2 (move "gi2c->cur = ..."
to be common between tx/rx and removed a pointless init of time_left).
Seems good. In total 7 lines shorter and easier to read.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
next prev parent reply other threads:[~2018-09-25 21:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 23:52 [PATCH v3 0/3] Fix qcom geni i2c DMA handling Stephen Boyd
2018-09-24 23:52 ` [PATCH v3 2/3] i2c: i2c-qcom-geni: Simplify tx/rx functions Stephen Boyd
2018-09-25 21:49 ` Doug Anderson [this message]
2018-10-04 7:28 ` alokc
2018-10-11 21:11 ` Wolfram Sang
2018-09-24 23:52 ` [PATCH v3 3/3] i2c: i2c-qcom-geni: Simplify irq handler Stephen Boyd
2018-09-25 21:49 ` Doug Anderson
2018-10-04 7:46 ` alokc
2018-10-11 21:11 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=X9yDF95NvuJGFMWJHBFS87VG4jJP946oH6w8gB3LGRvQ@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=girishm@codeaurora.org \
--cc=kramasub@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sdharia@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).