From: Doug Anderson <dianders@chromium.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kbuild@lists.01.org, Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
kbuild test robot <lkp@intel.com>,
kbuild-all@lists.01.org,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] HID: i2c-hid: goodix: Tie the reset line to true state of the regulator
Date: Fri, 25 Jun 2021 08:20:51 -0700 [thread overview]
Message-ID: <CAD=FV=XKzQ0GjifpvQgde3XmiBHaU3hXz3eLa_eoTngFhfBBkQ@mail.gmail.com> (raw)
In-Reply-To: <202106221609.teM1w2T0-lkp@intel.com>
Hi,
On Tue, Jun 22, 2021 at 1:49 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> 2b87ff72c696bc Douglas Anderson 2021-06-11 133 mutex_lock(&ihid_goodix->regulator_mutex);
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 2b87ff72c696bc Douglas Anderson 2021-06-11 134 ihid_goodix->nb.notifier_call = ihid_goodix_vdd_notify;
> 2b87ff72c696bc Douglas Anderson 2021-06-11 135 ret = regulator_register_notifier(ihid_goodix->vdd, &ihid_goodix->nb);
> 2b87ff72c696bc Douglas Anderson 2021-06-11 136 if (ret)
> 2b87ff72c696bc Douglas Anderson 2021-06-11 137 return dev_err_probe(&client->dev, ret,
> 2b87ff72c696bc Douglas Anderson 2021-06-11 138 "regulator notifier request failed\n");
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Drop the lock before returning?
Thank you for catching that. Fixed in v2:
https://lore.kernel.org/r/20210625081818.v2.1.I358cae5e33f742765fd38485d6ddf1a4a978644d@changeid/
-Doug
prev parent reply other threads:[~2021-06-25 15:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 16:28 [PATCH] HID: i2c-hid: goodix: Tie the reset line to true state of the regulator Douglas Anderson
2021-06-22 8:49 ` Dan Carpenter
2021-06-25 15:20 ` Doug Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=XKzQ0GjifpvQgde3XmiBHaU3hXz3eLa_eoTngFhfBBkQ@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=benjamin.tissoires@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=jikos@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).