From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755868AbbGFTdA (ORCPT <rfc822;w@1wt.eu>);
	Mon, 6 Jul 2015 15:33:00 -0400
Received: from mail-wg0-f48.google.com ([74.125.82.48]:36694 "EHLO
	mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755133AbbGFTc6 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 6 Jul 2015 15:32:58 -0400
MIME-Version: 1.0
In-Reply-To: <20150706183404.GI20779@saruman.tx.rr.com>
References: <1436207224-21849-1-git-send-email-dianders@chromium.org>
	<1436207224-21849-4-git-send-email-dianders@chromium.org>
	<20150706183404.GI20779@saruman.tx.rr.com>
Date: Mon, 6 Jul 2015 12:32:56 -0700
X-Google-Sender-Auth: L_a8SZowaXVgJm8JAaKC6ijxofc
Message-ID: <CAD=FV=XRY003C6ai4DFkcTogsW+g1AO955J_A4tB2tzu0PZy1Q@mail.gmail.com>
Subject: Re: [REPOST PATCH 3/3] USB: dwc2: Don't turn off the usbphy in
 suspend if wakeup is enabled
From: Doug Anderson <dianders@chromium.org>
To: Felipe Balbi <balbi@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        John Youn <johnyoun@synopsys.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        Chris Zhong <zyw@rock-chips.com>, Heiko Stuebner <heiko@sntech.de>,
        Julius Werner <jwerner@chromium.org>,
        Andrew Bresticker <abrestic@chromium.org>,
        Alexandru Stan <amstan@chromium.org>, lyz <lyz@rock-chips.com>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Felipe,

On Mon, Jul 6, 2015 at 11:34 AM, Felipe Balbi <balbi@ti.com> wrote:
> Hi,
>
> On Mon, Jul 06, 2015 at 11:27:04AM -0700, Douglas Anderson wrote:
>> @@ -282,6 +296,28 @@ static int dwc2_driver_probe(struct platform_device *dev)
>>       return retval;
>>  }
>>
>> +static bool __maybe_unused dwc2_can_poweroff_phy(struct dwc2_hsotg *dwc2)
>> +{
>> +     struct usb_device *root_hub = dwc2_hsotg_to_hcd(dwc2)->self.root_hub;
>
> what happens on peripheral only builds ?

The function is only called on if "dwc2_is_device_mode(dwc2)" returns
false.  I think that means we're safe, right?

-Doug