From: Doug Anderson <dianders@chromium.org>
To: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Sam Ravnborg <sam@ravnborg.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Robert Foss <robert.foss@linaro.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Subject: Re: [PATCH v3 1/3] drm/bridge: ti-sn65dsi86: Support DisplayPort (non-eDP) mode
Date: Thu, 10 Mar 2022 15:10:34 -0800 [thread overview]
Message-ID: <CAD=FV=XU5VGdKZ77UNb14Ah=LYKvSqbtBpzobMJYyMNDOXH2qg@mail.gmail.com> (raw)
In-Reply-To: <20220310152227.2122960-2-kieran.bingham+renesas@ideasonboard.com>
Hi,
On Thu, Mar 10, 2022 at 7:22 AM Kieran Bingham
<kieran.bingham+renesas@ideasonboard.com> wrote:
>
> From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>
> Despite the SN65DSI86 being an eDP bridge, on some systems its output is
> routed to a DisplayPort connector. Enable DisplayPort mode when the next
> component in the display pipeline is detected as a DisplayPort
> connector, and disable eDP features in that case.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reworked to set bridge type based on the next bridge/connector.
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> --
> Changes since v1/RFC:
> - Rebased on top of "drm/bridge: ti-sn65dsi86: switch to
> devm_drm_of_get_bridge"
> - eDP/DP mode determined from the next bridge connector type.
>
> Changes since v2:
> - Remove setting of Standard DP Scrambler Seed. (It's read-only).
> - Prevent setting DP_EDP_CONFIGURATION_SET in
> ti_sn_bridge_atomic_enable()
> - Use Doug's suggested text for disabling ASSR on DP mode.
>
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 23 ++++++++++++++++++++---
> 1 file changed, 20 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> index c892ecba91c7..93b54fcba8ba 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> @@ -62,6 +62,7 @@
> #define SN_LN_ASSIGN_REG 0x59
> #define LN_ASSIGN_WIDTH 2
> #define SN_ENH_FRAME_REG 0x5A
> +#define ASSR_CONTROL BIT(0)
nit that the ASSR_CONTROL define is no longer used.
Other than that, this patch looks fine to me.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
next prev parent reply other threads:[~2022-03-10 23:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 15:22 [PATCH v3 0/3] drm/bridge: ti-sn65dsi86: Support non-eDP DisplayPort connectors Kieran Bingham
2022-03-10 15:22 ` [PATCH v3 1/3] drm/bridge: ti-sn65dsi86: Support DisplayPort (non-eDP) mode Kieran Bingham
2022-03-10 16:18 ` Laurent Pinchart
2022-03-10 23:10 ` Doug Anderson [this message]
2022-03-10 15:22 ` [PATCH v3 2/3] drm/bridge: ti-sn65dsi86: Implement bridge connector operations Kieran Bingham
2022-03-10 16:23 ` Laurent Pinchart
2022-03-10 23:10 ` Doug Anderson
2022-03-16 23:24 ` Kieran Bingham
2022-03-10 15:22 ` [PATCH v3 3/3] drm/bridge: ti-sn65dsi86: Support hotplug detection Kieran Bingham
2022-03-10 15:26 ` Kieran Bingham
2022-03-10 16:42 ` Laurent Pinchart
2022-03-10 17:39 ` Kieran Bingham
2022-03-10 23:10 ` Doug Anderson
2022-03-11 5:47 ` Kieran Bingham
2022-03-11 15:24 ` Doug Anderson
2022-03-10 23:21 ` [PATCH v3 0/3] drm/bridge: ti-sn65dsi86: Support non-eDP DisplayPort connectors Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=XU5VGdKZ77UNb14Ah=LYKvSqbtBpzobMJYyMNDOXH2qg@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=andrzej.hajda@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robert.foss@linaro.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).