From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 525F2C432BE for ; Thu, 12 Aug 2021 20:08:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3117760FC0 for ; Thu, 12 Aug 2021 20:08:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234444AbhHLUIz (ORCPT ); Thu, 12 Aug 2021 16:08:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231384AbhHLUIw (ORCPT ); Thu, 12 Aug 2021 16:08:52 -0400 Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72FBFC0613D9 for ; Thu, 12 Aug 2021 13:08:26 -0700 (PDT) Received: by mail-io1-xd2f.google.com with SMTP id q16so7737270ioj.0 for ; Thu, 12 Aug 2021 13:08:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1bGQrduUL+m7VKRi0v0z85Q4dsnPpu6fOOpwbY1ffcA=; b=VkYCJom5pQdEVeQHfD3XlI4ousGOTHyxeSAvOpfTqiA6czSNTcbk54qIadf6AzTflf tuEyhtjXasOIcoOn/irN1qhAoj5mL8+7JP3Rmt1aqlq9OrRyvlUJ/JFa2Yo1lYJkNVUW aiVQWCBmqdke9ohe/yMCVhVBFLWk1Eag9+qWc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1bGQrduUL+m7VKRi0v0z85Q4dsnPpu6fOOpwbY1ffcA=; b=blkbArmhYHG6HG64+C3tZxHYzZ5lhskXOrLYL5U4g7Hou5+swO3Glb2E9Om6rw8+8S 5wIyyghtUMRZdzm/JRKxiRFAHks/7LUDyhgTWN4xU5kfyFk4cT+xONIYS+zYLo/gvJQF dojnr6XVJNAkdbvLOGqopdX1nk6GbtAo6B8fXbZO4k2cEUeJkD64vxNtoyuMIvSF1i5c UDRl6clVGIGoEY+ChE1OYKElS18TffHu7IbbHlUxs+7kkauFpiWKtLobTAsIqyvS2o0j a4TdsM06+oJDccxlfAcBKFXeARu94i0AdXbPJ2kqpmWkb2NQbu/2THqLyMQpll6qwme+ nlrg== X-Gm-Message-State: AOAM5314XQrqggPQydv44a9SMpAmGCIpDbMET5uoJqs9/Nj8PKqf6ZLG 0u5a9tqJUvcsf1eLHUO0282PI28IB+byYw== X-Google-Smtp-Source: ABdhPJwOUoVBNcVxcMAVYkMdiWAyMsJ8DEtm24GOEILxKlV0W91SpUdzI2pK2eINvjaT0DKt85jwwQ== X-Received: by 2002:a05:6602:26d2:: with SMTP id g18mr4223713ioo.194.1628798905625; Thu, 12 Aug 2021 13:08:25 -0700 (PDT) Received: from mail-il1-f178.google.com (mail-il1-f178.google.com. [209.85.166.178]) by smtp.gmail.com with ESMTPSA id x4sm2215821ilj.52.2021.08.12.13.08.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Aug 2021 13:08:25 -0700 (PDT) Received: by mail-il1-f178.google.com with SMTP id z2so8408357iln.0 for ; Thu, 12 Aug 2021 13:08:24 -0700 (PDT) X-Received: by 2002:a05:6e02:d49:: with SMTP id h9mr223667ilj.229.1628798904325; Thu, 12 Aug 2021 13:08:24 -0700 (PDT) MIME-Version: 1.0 References: <20210811235253.924867-1-robdclark@gmail.com> <20210811235253.924867-5-robdclark@gmail.com> In-Reply-To: From: Doug Anderson Date: Thu, 12 Aug 2021 13:08:11 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/4] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support To: Laurent Pinchart Cc: Rob Clark , dri-devel , linux-arm-msm , freedreno , Stephen Boyd , Rob Clark , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Laurent, On Thu, Aug 12, 2021 at 12:26 PM Laurent Pinchart wrote: > > Hi Rob, > > Thank you for the patch. > > On Wed, Aug 11, 2021 at 04:52:50PM -0700, Rob Clark wrote: > > From: Rob Clark > > > > Slightly awkward to fish out the display_info when we aren't creating > > own connector. But I don't see an obvious better way. > > We need a bit more than this, to support the NO_CONNECTOR case, the > bridge has to implement a few extra operations, and set the bridge .ops > field. I've submitted two patches to do so a while ago: > > - [RFC PATCH 08/11] drm/bridge: ti-sn65dsi86: Implement bridge connector operations ([1]) Rob asked me about this over IRC, so if he left it out and it's needed then it's my fault. However, I don't believe it's needed until your series making this bridge chip support full DP. For the the eDP case the bridge chip driver in ToT no longer queries the EDID itself. It simply provides an AUX bus to the panel driver and the panel driver queries the EDID. I think that means we don't need to add DRM_BRIDGE_OP_EDID, right? I was also wondering if in the full DP case we should actually model the physical DP jack as a drm_bridge and have it work the same way. It would get probed via the DP AUX bus just like a panel. I seem to remember Stephen Boyd was talking about modeling the DP connector as a drm_bridge because it would allow us to handle the fact that some TCPC chips could only support HBR2 whereas others could support HBR3. Maybe it would end up being a fairly elegant solution? > - [RFC PATCH 09/11] drm/bridge: ti-sn65dsi86: Make connector creation optional ([2]) > > The second patch is similar to the first half of this patch, but misses > the cleanup code. I'll try to rebase this and resubmit, but it may take > a bit of time. Whoops! You're right that Rob's patch won't work at all because we'll just hit the "Fix bridge driver to make connector optional!" case. I should have noticed that. :( -Doug