From: Doug Anderson <dianders@chromium.org>
To: sibis@codeaurora.org
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Evan Green <evgreen@chromium.org>,
benchan@chromium.org,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
tsoni@codeaurora.org
Subject: Re: [PATCH] arm64: dts: qcom: sdm845: Add reserve-memory nodes
Date: Mon, 29 Oct 2018 11:37:46 -0700 [thread overview]
Message-ID: <CAD=FV=Xf7NXTV_OtBePn9QUQbzdkMxdYg-yRua_6SbV-av3P+g@mail.gmail.com> (raw)
In-Reply-To: <20181026122745.5094-1-sibis@codeaurora.org>
Hi,
On Fri, Oct 26, 2018 at 5:28 AM Sibi Sankar <sibis@codeaurora.org> wrote:
>
> Add reserve-memory nodes for mpss and mba required for
> remoteproc mss pil.
>
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index d3fe012ad84e..f74892e447f9 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -88,6 +88,16 @@
> reg = <0 0x86200000 0 0x2d00000>;
> no-map;
> };
> +
> + mpss_region: reserved-memory@8e000000 {
> + no-map;
> + reg = <0 0x8e000000 0 0x7800000>;
> + };
> +
> + mba_region: reserved-memory@96500000 {
nit: All of the other reserved memory in this same section just has
the node name "memory". Can you please follow suit? Also above.
This is the kind of thing that Rob H. usually cares about doing right.
> + no-map;
> + reg = <0 0x96500000 0 0x200000>;
nit: All of the other reserved memory in this same section has "reg"
above "no-map". It doesn't matter a whole lot, but why not make it
match everyone else? Also above.
-Doug
next prev parent reply other threads:[~2018-10-29 18:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 12:27 [PATCH] arm64: dts: qcom: sdm845: Add reserve-memory nodes Sibi Sankar
2018-10-29 1:39 ` Bjorn Andersson
2018-10-29 18:37 ` Doug Anderson [this message]
2018-10-31 5:58 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=Xf7NXTV_OtBePn9QUQbzdkMxdYg-yRua_6SbV-av3P+g@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=andy.gross@linaro.org \
--cc=benchan@chromium.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sibis@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).