archive mirror
 help / color / mirror / Atom feed
From: Doug Anderson <>
To: Maulik Shah <>
Cc: Bjorn Andersson <>,
	Andy Gross <>,
	LKML <>,
	linux-arm-msm <>,
	Lina Iyer <>,
	Srinivas Rao L <>,
	Stephen Boyd <>
Subject: Re: [PATCH] drivers: qcom: rpmh-rsc: Do not read back the register write on trigger
Date: Thu, 3 Dec 2020 13:15:58 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>


On Tue, Nov 24, 2020 at 1:53 AM Maulik Shah <> wrote:
> From: Lina Iyer <>
> When triggering a TCS to send its contents, reading back the trigger
> value may return an incorrect value. That is because, writing the
> trigger may raise an interrupt which could be handled immediately and
> the trigger value could be reset in the interrupt handler.
> A write_tcs_reg_sync() would read back the value that is written and try
> to match it to the value written to ensure that the value is written,
> but if that value is different, we may see false error for same.
> Signed-off-by: Lina Iyer <>
> Signed-off-by: Maulik Shah <>
> ---
>  drivers/soc/qcom/rpmh-rsc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Fixes: 658628e7ef78 ("drivers: qcom: rpmh-rsc: add RPMH controller for
Signed-off-by: Douglas Anderson <>

  reply	other threads:[~2020-12-03 21:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-24  9:53 [PATCH] drivers: qcom: rpmh-rsc: Do not read back the register write on trigger Maulik Shah
2020-12-03 21:15 ` Doug Anderson [this message]
2020-12-03 21:17   ` Doug Anderson
2020-12-09 11:04     ` Maulik Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).