archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers: qcom: rpmh-rsc: Do not read back the register write on trigger
@ 2020-11-24  9:53 Maulik Shah
  2020-12-03 21:15 ` Doug Anderson
  0 siblings, 1 reply; 4+ messages in thread
From: Maulik Shah @ 2020-11-24  9:53 UTC (permalink / raw)
  To: bjorn.andersson, agross
  Cc: linux-kernel, linux-arm-msm, dianders, ilina, lsrao, Maulik Shah

From: Lina Iyer <>

When triggering a TCS to send its contents, reading back the trigger
value may return an incorrect value. That is because, writing the
trigger may raise an interrupt which could be handled immediately and
the trigger value could be reset in the interrupt handler.

A write_tcs_reg_sync() would read back the value that is written and try
to match it to the value written to ensure that the value is written,
but if that value is different, we may see false error for same.

Signed-off-by: Lina Iyer <>
Signed-off-by: Maulik Shah <>
 drivers/soc/qcom/rpmh-rsc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c
index 37969dc..0b082ec 100644
--- a/drivers/soc/qcom/rpmh-rsc.c
+++ b/drivers/soc/qcom/rpmh-rsc.c
@@ -364,7 +364,7 @@ static void __tcs_set_trigger(struct rsc_drv *drv, int tcs_id, bool trigger)
 		enable = TCS_AMC_MODE_ENABLE;
 		write_tcs_reg_sync(drv, RSC_DRV_CONTROL, tcs_id, enable);
 		enable |= TCS_AMC_MODE_TRIGGER;
-		write_tcs_reg_sync(drv, RSC_DRV_CONTROL, tcs_id, enable);
+		write_tcs_reg(drv, RSC_DRV_CONTROL, tcs_id, enable);
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-12-09 11:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-24  9:53 [PATCH] drivers: qcom: rpmh-rsc: Do not read back the register write on trigger Maulik Shah
2020-12-03 21:15 ` Doug Anderson
2020-12-03 21:17   ` Doug Anderson
2020-12-09 11:04     ` Maulik Shah

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).