From: Doug Anderson <dianders@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
V Sujith Kumar Reddy <vsujithk@codeaurora.org>,
Srinivasa Rao Mandadapu <srivasam@qti.qualcomm.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: Re: [PATCH] arm64: dts: qcom: sc7180-trogdor: Fix lpass dai link for HDMI
Date: Wed, 11 Aug 2021 15:28:02 -0700 [thread overview]
Message-ID: <CAD=FV=Xks_cSAEWMUxCriLbhAQ11CkVUrJJ97waMgGUVF7mPyg@mail.gmail.com> (raw)
In-Reply-To: <20210811194719.856593-1-swboyd@chromium.org>
Hi,
On Wed, Aug 11, 2021 at 12:47 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> This should be the dai for display port. Without this set properly we
> fail to get audio routed through external displays on trogdor. It looks
> like we picked up v4[1] of this patch when there was a v7[2]. The v7
> patch still had the wrong sound-dai but at least we can fix all this up
> and audio works.
>
> Cc: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
> Cc: Srinivasa Rao Mandadapu <srivasam@qti.qualcomm.com>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Fixes: b22d313e1772 ("arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for HDMI")
> Link: https://lore.kernel.org/r/20210721080549.28822-3-srivasam@qti.qualcomm.com [1]
> Link: https://lore.kernel.org/r/20210726120910.20335-3-srivasam@codeaurora.org [2]
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
There were other changes between v4 and v7. Do we want to take those
too? Basically two things discussed in my response to v5 [1].
1. I think we don't need `#sound-dai-cells = <0>;`
2. It seemed marginally better to call the node `hdmi@5`, not `hdmi-primary@5`.
Also, in case you're comparing to v7, it looks like v7 still had a
bug, though, that your patch fixes. It still had "sound-dai =
<&lpass_cpu 2>;"
So confusing!
[1] https://lore.kernel.org/linux-arm-msm/CAD=FV=W3X8W90vPdrDAymzTKj-J7QPyn4ukaLSOhEkCme3+r_Q@mail.gmail.com/
-Doug
next prev parent reply other threads:[~2021-08-11 22:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 19:47 [PATCH] arm64: dts: qcom: sc7180-trogdor: Fix lpass dai link for HDMI Stephen Boyd
2021-08-11 22:28 ` Doug Anderson [this message]
2021-08-11 22:41 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=Xks_cSAEWMUxCriLbhAQ11CkVUrJJ97waMgGUVF7mPyg@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=srivasam@qti.qualcomm.com \
--cc=swboyd@chromium.org \
--cc=vsujithk@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).