From: Doug Anderson <dianders@chromium.org>
To: Sibi Sankar <sibis@codeaurora.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
tsoni@codeaurora.org, clew@codeaurora.org,
akdwived@codeaurora.org, Mark Rutland <mark.rutland@arm.com>,
linux-remoteproc@vger.kernel.org,
Evan Green <evgreen@chromium.org>,
Brian Norris <briannorris@chromium.org>
Subject: Re: [PATCH v2 2/7] dt-bindings: remoteproc: qcom: Add clock bindings for Q6V5
Date: Tue, 18 Dec 2018 08:07:59 -0800 [thread overview]
Message-ID: <CAD=FV=Xuh0pUTcKOGPANmgfeGxQfHwN5RWg+E9srzuGq2_AmAQ@mail.gmail.com> (raw)
In-Reply-To: <8decd38d8e28c6657949f3c140947977@codeaurora.org>
Hi,
On Mon, Dec 17, 2018 at 9:52 PM Sibi Sankar <sibis@codeaurora.org> wrote:
> >> @@ -39,13 +39,17 @@ on the Qualcomm Hexagon core.
> >> - clocks:
> >> Usage: required
> >> Value type: <phandle>
> >> - Definition: reference to the iface, bus and mem clocks to be
> >> held on
> >> - behalf of the booting of the Hexagon core
> >> + Definition: reference to the list of 4 clocks for the modem
> >> sub-system
> >> + reference to the list of 8 clocks for the modem
> >> sub-system
> >> + on SDM845 SoCs
> >
> > The above is confusing because you don't list the SoCs that are
> > supposed to use the 4 clocks. How about instead:
> >
> > Definition: reference to the clocks that match clock-names
> >
>
> AFAIK, only the exceptions are captured. I am fine
> with both, I'll wait for Bjorn/Rob's preference.
Sure, waiting for Bjron / Rob to chime in sounds good. If you are
going to document just the exception, though, IMO at least reword it.
AKA:
reference to the list of 8 clocks for the modem sub-system on SDM845
SoCs; reference to the list of 4 clocks for the modem sub-system on
all other SoCs.
...the key being the "on all other" to make it clear. ...but I still
like my original suggestion of using less prose and more lists, so
hopefully Bjorn / Rob are OK with that.
-Doug
next prev parent reply other threads:[~2018-12-18 16:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 10:07 [PATCH v2 1/7] dt-bindings: soc: qcom: Add remote-pid binding for GLINK SMEM Sibi Sankar
2018-12-17 10:07 ` [PATCH v2 2/7] dt-bindings: remoteproc: qcom: Add clock bindings for Q6V5 Sibi Sankar
2018-12-17 23:59 ` Doug Anderson
2018-12-18 5:52 ` Sibi Sankar
2018-12-18 16:07 ` Doug Anderson [this message]
2018-12-18 17:27 ` Rob Herring
2018-12-19 7:04 ` Sibi Sankar
2018-12-17 10:07 ` [PATCH v2 3/7] dt-bindings: remoteproc: qcom: Fixup regulator dependencies Sibi Sankar
2018-12-18 0:00 ` Doug Anderson
2018-12-18 6:50 ` Sibi Sankar
2018-12-17 10:07 ` [PATCH v2 4/7] dt-bindings: remoteproc: qcom: Add power-domain bindings for Q6V5 Sibi Sankar
2018-12-18 0:01 ` Doug Anderson
2018-12-18 6:30 ` Sibi Sankar
2018-12-17 10:07 ` [PATCH v2 5/7] arm64: dts: qcom: sdm845: Add Q6V5 MSS node Sibi Sankar
2018-12-18 0:02 ` Doug Anderson
2018-12-18 6:35 ` Sibi Sankar
2018-12-18 16:00 ` kbuild test robot
2018-12-17 10:07 ` [PATCH v2 6/7] arm64: dts: qcom: sdm845: Add power-domain for " Sibi Sankar
2018-12-18 0:02 ` Doug Anderson
2018-12-18 6:38 ` Sibi Sankar
2018-12-17 10:07 ` [PATCH v2 7/7] arm64: dts: qcom: sdm845: Add shutdown-ack " Sibi Sankar
2018-12-18 0:02 ` Doug Anderson
2018-12-17 23:59 ` [PATCH v2 1/7] dt-bindings: soc: qcom: Add remote-pid binding for GLINK SMEM Doug Anderson
2018-12-18 5:16 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=Xuh0pUTcKOGPANmgfeGxQfHwN5RWg+E9srzuGq2_AmAQ@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=akdwived@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=briannorris@chromium.org \
--cc=clew@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sibis@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).