From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DA55C433E6 for ; Wed, 13 Jan 2021 00:51:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0FFDA2312F for ; Wed, 13 Jan 2021 00:51:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404843AbhAMAnA (ORCPT ); Tue, 12 Jan 2021 19:43:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392095AbhAMACz (ORCPT ); Tue, 12 Jan 2021 19:02:55 -0500 Received: from mail-vs1-xe32.google.com (mail-vs1-xe32.google.com [IPv6:2607:f8b0:4864:20::e32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC3F5C0617A3 for ; Tue, 12 Jan 2021 16:01:39 -0800 (PST) Received: by mail-vs1-xe32.google.com with SMTP id s2so178200vsk.2 for ; Tue, 12 Jan 2021 16:01:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X1O0kACakbx2RcXU3rpwMtnI8YwFi/QQJx5lWup4tPs=; b=TDD54LXJMIOHuHC7yNuKWAIpA7mi5lm/OaZT3vtTzB+EkbjAgXxIfvyiLWCvNt2eYd 7H015wWHRDVue0tnkGew/FoTWBQN5+AKOCCqt1KtEX+CVdeCsXBTX39Zm+9qh7Cme+C7 HYZTgCC2CbUmmy71bvcExAzSpON5Y5i8fhc5Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X1O0kACakbx2RcXU3rpwMtnI8YwFi/QQJx5lWup4tPs=; b=t5CtvcXmtXJYyww27iawSOBoRWwcBAcEe4qW67RmyGN6LZP3ZyefAe0q/y44dkR7lT z2fnzh8EHGFmPaHe89fUsMBHk3lRHYKTZIdkCWUak8zo3hUDT7sk2/fJBVUy7kJ2uNwn 8Y80jrVbawRlHxU981scK5+uZEkRY3MO+1BX/T3QyUw3UJsqPo4hUdZW9bJbVmjZrAvE etB+KwSR/NcmSOFxRlWUvFKc+3mXFmhM9FnsQHP0W8QMF+9NaeOcxmO8efX8o0C5+15n oZbzVGwIbu45ylGyG2rbocl6Qs9TlAUbDpFMz5aiM7hwTSF+h9hwuDZfOTq78mzF+mGA HEdw== X-Gm-Message-State: AOAM531Em7IVx7tioIMyFrI+5cFwnb9LEJxGhyS+nSezJysLcTDT4Amp S4rMq1nQ3oAzYeiGU1TbQtg5uoOACjYaWg== X-Google-Smtp-Source: ABdhPJwLqZBiUZ0xyXO74vJHgrqsLuRP14ckMBSbflBAv4O685Q15DFjtLh62TTiqj9FrilTzkzUUg== X-Received: by 2002:a67:e3a7:: with SMTP id j7mr1766357vsm.12.1610496098444; Tue, 12 Jan 2021 16:01:38 -0800 (PST) Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com. [209.85.217.46]) by smtp.gmail.com with ESMTPSA id i30sm52982uai.9.2021.01.12.16.01.37 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Jan 2021 16:01:37 -0800 (PST) Received: by mail-vs1-f46.google.com with SMTP id o19so174433vsn.3 for ; Tue, 12 Jan 2021 16:01:37 -0800 (PST) X-Received: by 2002:a67:7385:: with SMTP id o127mr2228991vsc.8.1610496096878; Tue, 12 Jan 2021 16:01:36 -0800 (PST) MIME-Version: 1.0 References: <20210111151651.1616813-1-vkoul@kernel.org> In-Reply-To: <20210111151651.1616813-1-vkoul@kernel.org> From: Doug Anderson Date: Tue, 12 Jan 2021 16:01:24 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/7] Add and enable GPI DMA users To: Vinod Koul Cc: Bjorn Andersson , Mark Brown , Wolfram Sang , linux-arm-msm , Andy Gross , Matthias Kaehlcke , Sumit Semwal , Amit Pundir , linux-spi , linux-i2c@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Jan 11, 2021 at 7:17 AM Vinod Koul wrote: > > Hello, > > This series add the GPI DMA in qcom geni spi and i2c drivers. For this we > first need to move GENI_IF_DISABLE_RO and struct geni_wrapper to common > headers and then add support for gpi dma in geni driver. > > Then we add spi and i2c geni driver changes to support this DMA. > > Lastly, add the GPI dma nodes and enable dma for spi found in Rb3 board. > > To merge this, we could merge all thru qcom tree with ack on spi/i2c. It'd be super great if somewhere (ideally in the commit message and maybe somewhere in the code) you could talk more about the different modes. Maybe something like this (if it's correct): GPI Mode (confusingly, also known as "GSI" mode in some places): In this mode something else running on the SoC is sharing access to the geni instance. This mode allows sharing the device between the Linux kernel and other users including handling the fact that other users might be running the geni port at a different clock rate. GPI mode limits what you can do with a port. For instance, direct control of chip select is not allowed. NOTE: if firmware has configured a geni instance for GPI then FIFO and SE_DMA usage is not allowed. Conversely, if firmware has not configured a geni instance for GPI then only FIFO and SE_DMA usage is allowed. SE DMA Mode: Data transfers happen over DMA. SE FIFO Mode: Data is manually transferred into the FIFO by the CPU.