From: Doug Anderson <dianders@chromium.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Taniya Das <tdas@codeaurora.org>,
Jeffrey Hugo <jhugo@codeaurora.org>,
Abhishek Sahu <absahu@codeaurora.org>,
sivaprak@codeaurora.org, anusharao@codeaurora.org,
Sricharan <sricharan@codeaurora.org>,
Rob Herring <robh@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Andy Gross <agross@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-clk <linux-clk@vger.kernel.org>
Subject: Re: [PATCH v2] dt-bindings: clk: qcom: Fix self-validation, split, and clean cruft
Date: Thu, 30 Jan 2020 10:17:37 -0800 [thread overview]
Message-ID: <CAD=FV=Xvw+oA70+JG-5wMy+0v5M324idQRJsujVbNnBtEF2gvQ@mail.gmail.com> (raw)
In-Reply-To: <20200130180404.6771A2083E@mail.kernel.org>
Hi,
On Thu, Jan 30, 2020 at 10:04 AM Stephen Boyd <sboyd@kernel.org> wrote:
>
> > Misc cleanups as part of this patch:
> > - sm8150 was claimed to be same set of clocks as sc7180, but driver
> > and dts appear to say that "bi_tcxo_ao" doesn't exist. Fixed.
>
> Someone will probably want to change this at some point.
I have no insight into sm8150, but I guess I assumed that since it
wasn't in the driver that maybe sm8150 just doesnt have this hookup?
I'm happy to add it back in.
> > +description:
> > + Qualcomm global clock control module which supports the clocks, resets and
> > + power domains on APQ8064.
>
> It would be great if this could also point to the
> include/dt-bindings/clock/qcom,apq8064.h file here. If you don't resend
> this patch then I will try to remember to make this addition to the
> binding docs.
You're saying that the top-level description for all these should
point to the header file? Seems line a sane idea. I guess we'd need
to do that for all of them? I could spin with that if you want, but
we could also do a follow-up patch?
-Doug
next prev parent reply other threads:[~2020-01-30 18:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 23:25 [PATCH v2] dt-bindings: clk: qcom: Fix self-validation, split, and clean cruft Douglas Anderson
2020-01-30 18:04 ` Stephen Boyd
2020-01-30 18:17 ` Doug Anderson [this message]
2020-02-03 17:09 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=Xvw+oA70+JG-5wMy+0v5M324idQRJsujVbNnBtEF2gvQ@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=absahu@codeaurora.org \
--cc=agross@kernel.org \
--cc=anusharao@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sivaprak@codeaurora.org \
--cc=sricharan@codeaurora.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).