From: Zhu Yanjun <zyjzyj2000@gmail.com>
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
RDMA mailing list <linux-rdma@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
syzbot+aab53008a5adf26abe91@syzkaller.appspotmail.com
Subject: Re: [PATCH] RDMA: fix use-after-free in rxe_queue_cleanup
Date: Mon, 22 Nov 2021 10:04:28 +0800 [thread overview]
Message-ID: <CAD=hENcbr22fW8YuoG2o2_MCNBjF7DW_sgLRpcC=qh24Edq=Dw@mail.gmail.com> (raw)
In-Reply-To: <20211121202239.3129-1-paskripkin@gmail.com>
On Mon, Nov 22, 2021 at 4:22 AM Pavel Skripkin <paskripkin@gmail.com> wrote:
>
> On error handling path in rxe_qp_from_init() qp->sq.queue is freed and
> then rxe_create_qp() will drop last reference to this object. qp clean
> up function will try to free this queue one time and it causes UAF bug.
>
> Fix it by zeroing queue pointer after freeing queue in
> rxe_qp_from_init().
>
> Fixes: 514aee660df4 ("RDMA: Globally allocate and release QP memory")
> Reported-by: syzbot+aab53008a5adf26abe91@syzkaller.appspotmail.com
> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Reviewed-by: Zhu Yanjun <zyjzyj2000@gmail.com>
Thanks a lot.
Zhu Yanjun
> ---
> drivers/infiniband/sw/rxe/rxe_qp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_qp.c b/drivers/infiniband/sw/rxe/rxe_qp.c
> index 975321812c87..54b8711321c1 100644
> --- a/drivers/infiniband/sw/rxe/rxe_qp.c
> +++ b/drivers/infiniband/sw/rxe/rxe_qp.c
> @@ -359,6 +359,7 @@ int rxe_qp_from_init(struct rxe_dev *rxe, struct rxe_qp *qp, struct rxe_pd *pd,
>
> err2:
> rxe_queue_cleanup(qp->sq.queue);
> + qp->sq.queue = NULL;
> err1:
> qp->pd = NULL;
> qp->rcq = NULL;
> --
> 2.33.1
>
next prev parent reply other threads:[~2021-11-22 2:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 9:27 [syzbot] KASAN: use-after-free Read in rxe_queue_cleanup syzbot
2021-11-20 15:02 ` Pavel Skripkin
2021-11-21 14:15 ` Leon Romanovsky
2021-11-21 14:43 ` Zhu Yanjun
2021-11-21 20:22 ` [PATCH] RDMA: fix use-after-free " Pavel Skripkin
2021-11-22 2:04 ` Zhu Yanjun [this message]
2021-11-25 17:25 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=hENcbr22fW8YuoG2o2_MCNBjF7DW_sgLRpcC=qh24Edq=Dw@mail.gmail.com' \
--to=zyjzyj2000@gmail.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=paskripkin@gmail.com \
--cc=syzbot+aab53008a5adf26abe91@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).