From: Chao Xie <xiechao.mail@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Chao Xie <chao.xie@marvell.com>,
Alan Stern <stern@rowland.harvard.edu>,
"balbi@ti.com" <balbi@ti.com>, Roger Quadros <rogerq@ti.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2] USB: initialize or shutdown PHY when add or remove host controller
Date: Wed, 19 Jun 2013 11:23:00 +0800 [thread overview]
Message-ID: <CADApbeikx1yrjVKOREHq45qZDmxF872FY2tN7WBkhPYY=Uxkcw@mail.gmail.com> (raw)
In-Reply-To: <20130619024839.GA1987@kroah.com>
On Wed, Jun 19, 2013 at 10:48 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Tue, Jun 18, 2013 at 10:31:20PM -0400, Chao Xie wrote:
>> Some controller need software to initialize PHY before add
>> host controller, and shut down PHY after remove host controller.
>> Add the generic code for these controllers so they do not need
>> do it in its own host controller driver.
>
> Why? What breaks if we add this patch, and what gets fixed? I'm
> guessing you can then remove code?
>
> What out-of-tree code now works properly? Or gets broken?
>
> we need more info here please...
>
The patch does not fix any bug.
Some echi-xxx driver will need initialize the phy before it do
usb_add_hcd, and shut down phy after
do usb_remove_hcd, and i did a patch for ehci-mv.c to do above thing.
Alan and Felipe comments on my patch, and they think it is a peice of
generic code, and it can be
moved to hcd to handle it, so other ehci-xxx will not do the same thing again.
So i add the patch to add the generic code in hcd to handle phy
initialization and shut down.
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2013-06-19 3:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 2:31 [PATCH V2] USB: initialize or shutdown PHY when add or remove host controller Chao Xie
2013-06-19 2:48 ` Greg KH
2013-06-19 3:23 ` Chao Xie [this message]
2013-06-19 7:51 ` Roger Quadros
2013-06-20 0:53 ` Chao Xie
2013-06-20 12:17 ` Felipe Balbi
2013-06-20 17:25 ` Alan Stern
2013-06-21 1:07 ` Chao Xie
2013-06-21 1:27 ` Chao Xie
2013-06-24 19:45 ` Felipe Balbi
2013-06-25 1:25 ` Chao Xie
2013-06-25 3:33 ` Felipe Balbi
2013-06-24 19:36 ` Felipe Balbi
2013-06-25 13:37 ` Roger Quadros
2013-06-25 13:43 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADApbeikx1yrjVKOREHq45qZDmxF872FY2tN7WBkhPYY=Uxkcw@mail.gmail.com' \
--to=xiechao.mail@gmail.com \
--cc=balbi@ti.com \
--cc=chao.xie@marvell.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).