From: Baolin Wang <baolin.wang7@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: mark.rutland@arm.com, jassisinghbrar@gmail.com,
Orson Zhai <orsonzhai@gmail.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: mailbox: Add the Spreadtrum mailbox documentation
Date: Fri, 13 Mar 2020 10:19:38 +0800 [thread overview]
Message-ID: <CADBw62r6xvRW6i3f8NDf-OWTNimE_B8ewoFuOfcMgRUkM8B7gA@mail.gmail.com> (raw)
In-Reply-To: <20200312191616.GA9697@bogus>
Hi Rob,
On Fri, Mar 13, 2020 at 3:16 AM Rob Herring <robh@kernel.org> wrote:
>
> On Fri, Mar 06, 2020 at 02:07:21PM +0800, Baolin Wang wrote:
> > From: Baolin Wang <baolin.wang@unisoc.com>
> >
> > Add the Spreadtrum mailbox documentation.
> >
> > Signed-off-by: Baolin Wang <baolin.wang@unisoc.com>
> > Signed-off-by: Baolin Wang <baolin.wang7@gmail.com>
> > ---
> > .../devicetree/bindings/mailbox/sprd-mailbox.yaml | 56 ++++++++++++++++++++++
> > 1 file changed, 56 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml
> > new file mode 100644
> > index 0000000..2f2fdcf
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml
> > @@ -0,0 +1,56 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/mailbox/sprd-mailbox.yaml#"
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> > +
> > +title: Spreadtrum mailbox controller bindings
> > +
> > +maintainers:
> > + - Orson Zhai <orsonzhai@gmail.com>
> > + - Baolin Wang <baolin.wang7@gmail.com>
> > + - Chunyan Zhang <zhang.lyra@gmail.com>
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - sprd,sc9860-mailbox
> > +
> > + reg:
> > + minItems: 2
>
> Need to define what each entry is.
Sure
>
> > +
> > + interrupts:
> > + minItems: 2
> > + description:
> > + Contains the inbox and outbox interrupt information.
>
> The description should be split to define each entry:
>
> items:
> - description: inbox interrupt
> - description: outbox interrupt
Sure.
>
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > + clock-names:
> > + items:
> > + - const: enable
> > +
> > + "#mbox-cells":
> > + const: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - "#mbox-cells"
> > + - clocks
> > + - clock-names
>
> Add:
>
> additionalProperties: false
OK. Thanks for your comments.
--
Baolin Wang
prev parent reply other threads:[~2020-03-13 2:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 6:07 [PATCH 1/2] dt-bindings: mailbox: Add the Spreadtrum mailbox documentation Baolin Wang
2020-03-06 6:07 ` [PATCH 2/2] mailbox: sprd: Add Spreadtrum mailbox driver Baolin Wang
2020-03-12 19:16 ` [PATCH 1/2] dt-bindings: mailbox: Add the Spreadtrum mailbox documentation Rob Herring
2020-03-13 2:19 ` Baolin Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADBw62r6xvRW6i3f8NDf-OWTNimE_B8ewoFuOfcMgRUkM8B7gA@mail.gmail.com \
--to=baolin.wang7@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=orsonzhai@gmail.com \
--cc=robh@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).