From: "Jörg Otte" <jrg.otte@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Borislav Petkov <bp@alien8.de>
Subject: Re: [v4.17-rcx] Lost IBPB, IBRS_FW support for spectre_v2 mitigation.
Date: Wed, 2 May 2018 09:43:31 +0200 [thread overview]
Message-ID: <CADDKRnC1V3KUR__PAo_JhMVdaWknQ9x1_XAQNewUWuO3cqFFFg@mail.gmail.com> (raw)
In-Reply-To: <CA+55aFxKbPDrMQssyEtOnYZqE8HcOo=Zx6ASty6CybhwPfT9_g@mail.gmail.com>
2018-05-01 22:14 GMT+02:00 Linus Torvalds <torvalds@linux-foundation.org>:
> On Tue, May 1, 2018 at 5:59 AM Thomas Gleixner <tglx@linutronix.de> wrote:
>
>> Then I really have no idea how reverting the patch you pointed out would
>> fix it.
>
> So I do think that the original patch is buggy.
>
> What I think *may* be going on is:
>
> - first we do that
>
> get_cpu_cap(c);
> get_cpu_address_sizes(c);
>
> but at that point, CPU levels may be masked, and that 0x80000008 leaf
> isn't seen
>
> - then we do
>
> if (this_cpu->c_early_init)
> this_cpu->c_early_init(c);
>
> which calls early_init_intel(), which does that
>
> if (msr_clear_bit(MSR_IA32_MISC_ENABLE,
> MSR_IA32_MISC_ENABLE_LIMIT_CPUID_BIT) >
> 0) {
>
> which now raises the cpuid_level.
>
> - then we do
>
> get_cpu_cap(c);
>
> again, because the cpuid level has been raised, and _now_ it used to get
> that 0x80000008 leaf information.
>
> But with the change, that second call to get_cpu_cap() didn't do anything,
> because the 0x80000008 leaf handling had been moved away.
>
> However, I agree that your patch to just do that CPUID_8000_0008_EBX in
> get_cpu_cap() should have fixed it, and it's possible that Jörg mis-tested
> it.
>
> Jörg, are you sure you didn't somehow get the wrong microcode? Because
> another way for those bits to be cleared again is if
> bad_spectre_microcode() triggers. That should show up in dmesg as "Intel
> Spectre v2 broken microcode detected" though.
>
> Linus
I downloaded microcode from Intel.
Here are the excerpts from dmesg:
With revert:
jojo@fichte:~$ dmesg | grep -i -e spec -e micro -e "Linux version"
[ 0.000000] microcode: microcode updated early to revision 0x24,
date = 2018-01-21
[ 0.000000] Linux version 4.17.0-rc3-revert-00001-gcb1069f
(jojo@fichte) (gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubu
dmesg | grep -i -e spec -e micro -e "Linux version"
[ 0.000000] microcode: microcode updated early to revision 0x24,
date = 2018-01-21
[ 0.000000] Linux version 4.17.0-rc3-patch-00001-gdc10603
(jojo@fichte) (gcc version 5.4.0 20160609 (Ubuntu
5.4.0-6ubuntu1~16.04.9)) #20 SMP Wed May 2 09:08:07 CEST 2018
[ 0.028417] Spectre V2 : Mitigation: Full generic retpoline
[ 0.491803] microcode: sig=0x306c3, pf=0x10, revision=0x24
[ 0.491831] microcode: Microcode Update Driver: v2.2.ntu1~16.04.9))
#21 SMP Wed May 2 09:14:29 CEST 2018
[ 0.028414] Spectre V2 : Mitigation: Full generic retpoline
[ 0.028415] Spectre V2 : Spectre v2 mitigation: Enabling Indirect
Branch Prediction Barrier
[ 0.028415] Spectre V2 : Enabling Restricted Speculation for firmware calls
[ 0.500157] microcode: sig=0x306c3, pf=0x10, revision=0x24
[ 0.500183] microcode: Microcode Update Driver: v2.2.
With patch:
dmesg | grep -i -e spec -e micro -e "Linux version"
[ 0.000000] microcode: microcode updated early to revision 0x24,
date = 2018-01-21
[ 0.000000] Linux version 4.17.0-rc3-patch-00001-gdc10603
(jojo@fichte) (gcc version 5.4.0 20160609 (Ubuntu
5.4.0-6ubuntu1~16.04.9)) #20 SMP Wed May 2 09:08:07 CEST 2018
[ 0.028417] Spectre V2 : Mitigation: Full generic retpoline
[ 0.491803] microcode: sig=0x306c3, pf=0x10, revision=0x24
[ 0.491831] microcode: Microcode Update Driver: v2.2.
Thanks, Jörg
next prev parent reply other threads:[~2018-05-02 7:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 15:59 [v4.17-rcx] Lost IBPB, IBRS_FW support for spectre_v2 mitigation Jörg Otte
2018-04-30 19:53 ` Thomas Gleixner
2018-05-01 7:39 ` Jörg Otte
2018-05-01 12:59 ` Thomas Gleixner
2018-05-01 18:27 ` Thomas Gleixner
2018-05-01 23:07 ` Tim Chen
2018-05-01 20:14 ` Linus Torvalds
2018-05-02 7:43 ` Jörg Otte [this message]
2018-05-02 9:02 ` Thomas Gleixner
2018-05-02 9:25 ` Jörg Otte
2018-05-02 12:20 ` Thomas Gleixner
2018-05-04 16:18 ` Borislav Petkov
2018-05-05 9:47 ` Jörg Otte
2018-05-05 9:53 ` Borislav Petkov
2018-05-02 14:48 ` [tip:x86/urgent] x86/cpu: Restore CPUID_8000_0008_EBX reload tip-bot for Thomas Gleixner
2018-05-02 18:08 ` Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADDKRnC1V3KUR__PAo_JhMVdaWknQ9x1_XAQNewUWuO3cqFFFg@mail.gmail.com \
--to=jrg.otte@gmail.com \
--cc=bp@alien8.de \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).