From: Weidong Cui <weidongcui@gmail.com>
To: "Moore, Robert" <robert.moore@intel.com>
Cc: "Kaneda, Erik" <erik.kaneda@intel.com>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
Xinyang Ge <aegiryy@gmail.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"devel@acpica.org" <devel@acpica.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH] Enable ACPI_ADR_SPACE_PCI_CONFIG in acpi_gbl_default_address_spaces only when ACPI_PCI_CONFIGURED is defined
Date: Fri, 5 Mar 2021 06:48:34 -0800 [thread overview]
Message-ID: <CADFYyO5wtwfUrNWjW_uN_ctdgNzQywsHUtGoLkBaUc2652OGzA@mail.gmail.com> (raw)
In-Reply-To: <BYAPR11MB3256FD804E3F3CE584B6D3B387979@BYAPR11MB3256.namprd11.prod.outlook.com>
On Thu, Mar 4, 2021 at 9:37 AM Moore, Robert <robert.moore@intel.com> wrote:
> It is required in aclinux.h, and thus it is required in every host-dependent configuration file (acfreebsd.h, acmacosx.h, acnetbsd.h, achaiku.h, etc.) I would rather not force these host-specific header files to change.
> Bob
Hi Bob,
I don't know the reason for ACPI_PCI_CONFIGURED to be introduced into
aclinux.h. That patch introduced the bug I'm trying to fix: if
CONFIG_PCI is not enabled, the kernel will crash. Would it be okay to
accept this patch first to fix this kernel crash bug? We can come up
a plan to fix this host-dependent configuration issue in a separate
patch. What do you think?
@Erik, I would love to hear your thoughts on this.
Thank you!
Weidong
> > -----Original Message-----
> > From: Kaneda, Erik <erik.kaneda@intel.com>
> > Sent: Wednesday, March 03, 2021 10:29 AM
> > To: Weidong Cui <weidongcui@gmail.com>; Moore, Robert
> > <robert.moore@intel.com>; Wysocki, Rafael J
> > <rafael.j.wysocki@intel.com>
> > Cc: Xinyang Ge <aegiryy@gmail.com>; linux-acpi@vger.kernel.org;
> > devel@acpica.org; linux-kernel@vger.kernel.org; Len Brown
> > <lenb@kernel.org>
> > Subject: RE: [PATCH] Enable ACPI_ADR_SPACE_PCI_CONFIG in
> > acpi_gbl_default_address_spaces only when ACPI_PCI_CONFIGURED is
> > defined
> >
> > This looks good to me. Bob, do you have any comments?
> >
> > Erik
> >
> > > -----Original Message-----
> > > From: Weidong Cui <weidongcui@gmail.com>
> > > Sent: Monday, February 8, 2021 7:18 PM
> > > To: Moore, Robert <robert.moore@intel.com>; Kaneda, Erik
> > > <erik.kaneda@intel.com>; Wysocki, Rafael J
> > > <rafael.j.wysocki@intel.com>; Len Brown <lenb@kernel.org>
> > > Cc: Weidong Cui <weidongcui@gmail.com>; Xinyang Ge
> > > <aegiryy@gmail.com>; linux-acpi@vger.kernel.org; devel@acpica.org;
> > > linux- kernel@vger.kernel.org
> > > Subject: [PATCH] Enable ACPI_ADR_SPACE_PCI_CONFIG in
> > > acpi_gbl_default_address_spaces only when ACPI_PCI_CONFIGURED is
> > > defined
> > >
> > > Signed-off-by: Weidong Cui <weidongcui@gmail.com>
> > > Signed-off-by: Xinyang Ge <aegiryy@gmail.com>
> > > ---
> > > drivers/acpi/acpica/evhandler.c | 2 ++
> > > include/acpi/acconfig.h | 4 ++++
> > > 2 files changed, 6 insertions(+)
> > >
> > > diff --git a/drivers/acpi/acpica/evhandler.c
> > > b/drivers/acpi/acpica/evhandler.c index 5884eba04..4c25ad433 100644
> > > --- a/drivers/acpi/acpica/evhandler.c
> > > +++ b/drivers/acpi/acpica/evhandler.c
> > > @@ -26,7 +26,9 @@ acpi_ev_install_handler(acpi_handle obj_handle,
> > > u8 acpi_gbl_default_address_spaces[ACPI_NUM_DEFAULT_SPACES] = {
> > > ACPI_ADR_SPACE_SYSTEM_MEMORY,
> > > ACPI_ADR_SPACE_SYSTEM_IO,
> > > +#ifdef ACPI_PCI_CONFIGURED
> > > ACPI_ADR_SPACE_PCI_CONFIG,
> > > +#endif
> > > ACPI_ADR_SPACE_DATA_TABLE
> > > };
> > >
> > > diff --git a/include/acpi/acconfig.h b/include/acpi/acconfig.h index
> > > a225eff49..790999028 100644
> > > --- a/include/acpi/acconfig.h
> > > +++ b/include/acpi/acconfig.h
> > > @@ -162,7 +162,11 @@
> > > /* Maximum space_ids for Operation Regions */
> > >
> > > #define ACPI_MAX_ADDRESS_SPACE 255
> > > +#ifdef ACPI_PCI_CONFIGURED
> > > #define ACPI_NUM_DEFAULT_SPACES 4
> > > +#else
> > > +#define ACPI_NUM_DEFAULT_SPACES 3
> > > +#endif
> > >
> > > /* Array sizes. Used for range checking also */
> > >
> > > --
> > > 2.24.3 (Apple Git-128)
> >
next prev parent reply other threads:[~2021-03-05 14:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 3:17 [PATCH] Enable ACPI_ADR_SPACE_PCI_CONFIG in acpi_gbl_default_address_spaces only when ACPI_PCI_CONFIGURED is defined Weidong Cui
2021-02-09 14:35 ` Rafael J. Wysocki
[not found] ` <CADFYyO63S4xZHJh9Cw1NYa7W=D8h=ZtUG1qPeLxfQ88kvW7MRQ@mail.gmail.com>
[not found] ` <MWHPR11MB159925DE73F89A71D5E67113F0859@MWHPR11MB1599.namprd11.prod.outlook.com>
2021-03-01 15:10 ` Weidong Cui
2021-03-03 18:29 ` Kaneda, Erik
2021-03-04 16:56 ` Moore, Robert
2021-03-04 17:06 ` Weidong Cui
2021-03-04 17:36 ` Moore, Robert
2021-03-05 14:48 ` Weidong Cui [this message]
2021-03-05 20:46 ` Moore, Robert
2021-03-05 20:55 ` Weidong Cui
2021-03-25 1:44 ` Weidong Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADFYyO5wtwfUrNWjW_uN_ctdgNzQywsHUtGoLkBaUc2652OGzA@mail.gmail.com \
--to=weidongcui@gmail.com \
--cc=aegiryy@gmail.com \
--cc=devel@acpica.org \
--cc=erik.kaneda@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).