From: Zhihui Zhang <zzhsuny@gmail.com>
To: John Stultz <john.stultz@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] timers: Reconcile the code and the comment for the 250HZ case
Date: Sat, 21 Jan 2017 10:06:00 -0500 [thread overview]
Message-ID: <CADFvMY+A3GTz6XFr_EszT_dNf9sasQOeeskx0yST_mmf+h0r-Q@mail.gmail.com> (raw)
In-Reply-To: <CALAqxLX-XGj+65RW9NBLfQum6X9q=+1=MvydSdUsrZWtEf_EmA@mail.gmail.com>
Sure, I believe that comments should always match the code. In this
case, using either LVL_SIZE - 1 or LVL_SIZE is fine based on my
understanding about 20 days ago. But I could be wrong and miss some
subtle details. Anyway, my point is about readability.
thanks,
On Fri, Jan 20, 2017 at 5:41 PM, John Stultz <john.stultz@linaro.org> wrote:
> On Mon, Jan 2, 2017 at 1:14 PM, Zhihui Zhang <zzhsuny@gmail.com> wrote:
>> Adjust the time start of each level to match the comments. Note that
>> LVL_START(n) is never used for n = 0 case. Also, each level (except
>> level 0) has more than enough room to accommodate all its timers.
>
> So instead of just covering what your patch does, can you explain in
> some detail why this patch is useful? What net effect does it bring?
> What sort of bugs would it solve?
>
> thanks
> -john
next prev parent reply other threads:[~2017-01-21 15:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 21:14 [PATCH] timers: Reconcile the code and the comment for the 250HZ case Zhihui Zhang
2017-01-20 22:41 ` John Stultz
2017-01-21 15:06 ` Zhihui Zhang [this message]
2017-01-23 11:10 ` Thomas Gleixner
2017-01-24 23:51 ` Zhihui Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADFvMY+A3GTz6XFr_EszT_dNf9sasQOeeskx0yST_mmf+h0r-Q@mail.gmail.com \
--to=zzhsuny@gmail.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).