linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Qiujun Huang <anenbupt@gmail.com>
To: Will Deacon <will@kernel.org>
Cc: Kees Cook <keescook@chromium.org>,
	syzbot <syzbot+cea71eec5d6de256d54d@syzkaller.appspotmail.com>,
	ardb@kernel.org, davem@davemloft.net, guohanjun@huawei.com,
	kuba@kernel.org, linux-kernel@vger.kernel.org,
	linux-sctp@vger.kernel.org, marcelo.leitner@gmail.com,
	mingo@kernel.org, netdev@vger.kernel.org, nhorman@tuxdriver.com,
	syzkaller-bugs@googlegroups.com, vyasevich@gmail.com
Subject: Re: WARNING: refcount bug in sctp_wfree
Date: Tue, 17 Mar 2020 00:25:16 +0800	[thread overview]
Message-ID: <CADG63jDcuBNOVRoRX7oi1YmwuN0g7jpvDB4yNdOxwc13hvoNxA@mail.gmail.com> (raw)
In-Reply-To: <20200316155119.GB13004@willie-the-truck>

On Mon, Mar 16, 2020 at 11:52 PM Will Deacon <will@kernel.org> wrote:
>
> On Tue, Mar 10, 2020 at 09:01:18AM -0700, Kees Cook wrote:
> > On Tue, Mar 10, 2020 at 02:39:01AM -0700, syzbot wrote:
> > > syzbot has bisected this bug to:
> > >
> > > commit fb041bb7c0a918b95c6889fc965cdc4a75b4c0ca
> > > Author: Will Deacon <will@kernel.org>
> > > Date:   Thu Nov 21 11:59:00 2019 +0000
> > >
> > >     locking/refcount: Consolidate implementations of refcount_t
> >
> > I suspect this is just bisecting to here because it made the refcount
> > checks more strict?
>
> Yes, this is the commit that enables full refcount checking for all
> architectures unconditionally, so it's the canary in the coalmine rather
> than the source of the problem.

Yes, I tracked it down. And sent out a fix:
https://lore.kernel.org/netdev/1584330804-18477-1-git-send-email-hqjagain@gmail.com

>
> Will

  reply	other threads:[~2020-03-16 16:25 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-10  1:35 WARNING: refcount bug in sctp_wfree syzbot
2020-03-10  9:39 ` syzbot
2020-03-10 16:01   ` Kees Cook
2020-03-16 15:51     ` Will Deacon
2020-03-16 16:25       ` Qiujun Huang [this message]
2020-03-10 16:45 ` 黄秋钧
2020-03-11 15:00 ` Qiujun Huang
2020-03-14  2:51   ` Qiujun Huang
2020-03-14  2:59     ` Qiujun Huang
2020-03-14  2:54 ` Qiujun Huang
2020-03-14  2:55   ` Qiujun Huang
2020-03-14  4:08     ` syzbot
2020-03-14  4:04   ` syzbot
2020-03-14  5:10 ` Qiujun Huang
2020-03-14  9:03   ` syzbot
2020-03-15  7:59 ` Qiujun Huang
2020-03-15  8:12   ` syzbot
2020-03-20 11:11 ` Qiujun Huang
2020-03-20 14:28   ` syzbot
2020-03-22  4:11 ` Qiujun Huang
2020-03-22  4:39   ` syzbot
2020-03-22  6:41     ` Qiujun Huang
2020-03-22  7:18       ` syzbot
2020-03-26 15:38 ` Qiujun Huang
2020-03-26 15:38   ` syzbot
2020-03-26 15:38   ` syzbot
2020-03-26 15:53     ` Qiujun Huang
2020-03-26 15:53       ` syzbot
2020-03-26 16:17         ` Qiujun Huang
2020-03-26 21:25           ` syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADG63jDcuBNOVRoRX7oi1YmwuN0g7jpvDB4yNdOxwc13hvoNxA@mail.gmail.com \
    --to=anenbupt@gmail.com \
    --cc=ardb@kernel.org \
    --cc=davem@davemloft.net \
    --cc=guohanjun@huawei.com \
    --cc=keescook@chromium.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sctp@vger.kernel.org \
    --cc=marcelo.leitner@gmail.com \
    --cc=mingo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=syzbot+cea71eec5d6de256d54d@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=vyasevich@gmail.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).