From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756845Ab3GLDqd (ORCPT ); Thu, 11 Jul 2013 23:46:33 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:37645 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756581Ab3GLDqb (ORCPT ); Thu, 11 Jul 2013 23:46:31 -0400 MIME-Version: 1.0 In-Reply-To: <51CC6B09.5080809@infradead.org> References: <1371560680.3495.121.camel@deadeye.wl.decadent.org.uk> <51C07608.2070406@infradead.org> <51CC6B09.5080809@infradead.org> Date: Fri, 12 Jul 2013 11:46:30 +0800 Message-ID: Subject: Re: [PATCH]amilo-rfkill: add depends on i8042 in Kconfig From: Xiong Zhou To: Randy Dunlap Cc: Ben Hutchings , matthew.garrett@nebula.com, platform-driver-x86@vger.kernel.org, Linux-Next , "linux-kernel@vger.kernel.org" , Stephen Rothwell , Jim Davis , Jiri Kosina Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2013/6/28 Randy Dunlap : > On 06/18/13 18:09, Xiong Zhou wrote: >> 2013/6/18 Randy Dunlap : >>> On 06/18/13 06:04, Ben Hutchings wrote: >>>> On Tue, 2013-06-18 at 17:21 +0800, Xiong Zhou wrote: >>>>> From: Xiong Zhou >>>>> >>>>> Fix randconfig build failure for Amilo x86 platform driver. >>>>> AMILO_RFKILL requires SERIO_I8042 being available. >>>>> >>>>> amilo-rfkill.c:(.text+0x108b5b): undefined reference to `i8042_lock_chip' >>>>> amilo-rfkill.c:(.text+0x108b69): undefined reference to `i8042_command' >>>>> amilo-rfkill.c:(.text+0x108b71): undefined reference to `i8042_unlock_chip' >>>>> >>>>> Reported-by: Jim Davis >>>>> Signed-off-by: Xiong Zhou >>>> >>>> Acked-by: Ben Hutchings >>>> >>>> But I thought somehow sent this same fix a while back... >>> >>> Yes, I reported it and sent a patch for it that you acked... >>> I guess my patch was never picked up. >>> >> >> ... Better someone pick this up. >> > > This build error is still occurring in linux-next (20130627). > I first reported it and posted a patch for it on May-15 2013. > > Please merge either patch... > > Is anybody out there? > > >> >>>> >>>> Ben. >>>> >>>>> --- >>>>> drivers/platform/x86/Kconfig | 1 + >>>>> 1 file changed, 1 insertion(+) >>>>> >>>>> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig >>>>> index 8577261..37645b9 100644 >>>>> --- a/drivers/platform/x86/Kconfig >>>>> +++ b/drivers/platform/x86/Kconfig >>>>> @@ -176,6 +176,7 @@ config FUJITSU_TABLET >>>>> config AMILO_RFKILL >>>>> tristate "Fujitsu-Siemens Amilo rfkill support" >>>>> depends on RFKILL >>>>> + depends on SERIO_I8042 >>>>> ---help--- >>>>> This is a driver for enabling wifi on some Fujitsu-Siemens Amilo >>>>> laptops. >>>> >>> >>> >>> -- >>> ~Randy >> -- > > > -- > ~Randy cc Jiri Kosina