linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Austin Kim <austindh.kim@gmail.com>
To: aacraid@microsemi.com, jejb@linux.ibm.com, martin.petersen@oracle.com
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: dpt_i2o: drop unnecessary comparison statement
Date: Tue, 10 Sep 2019 20:17:59 +0900	[thread overview]
Message-ID: <CADLLry4CjS+1syBCf68BFUbWxZJ8UGcUphinE1Hs7FRvdK0ikg@mail.gmail.com> (raw)
In-Reply-To: <20190909054219.GA119246@LGEARND20B15>

Hello, Maintainers...
Would you please review this patch and share the feedback?

Thanks,
Austin Kim

2019년 9월 9일 (월) 오후 2:42, Austin Kim <austindh.kim@gmail.com>님이 작성:
>
> The type of 'chan' is u32 which contain non-negative value.
> So 'chan < 0' is statment is always false.
>
> Remove unnecessary comparison statement
>
> Signed-off-by: Austin Kim <austindh.kim@gmail.com>
> ---
>  drivers/scsi/dpt_i2o.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
> index abc74fd..df48ef5 100644
> --- a/drivers/scsi/dpt_i2o.c
> +++ b/drivers/scsi/dpt_i2o.c
> @@ -1120,7 +1120,7 @@ static struct adpt_device* adpt_find_device(adpt_hba* pHba, u32 chan, u32 id, u6
>  {
>         struct adpt_device* d;
>
> -       if(chan < 0 || chan >= MAX_CHANNEL)
> +       if(chan >= MAX_CHANNEL)
>                 return NULL;
>
>         d = pHba->channel[chan].device[id];
> --
> 2.6.2
>

      reply	other threads:[~2019-09-10 11:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-09  5:42 [PATCH] scsi: dpt_i2o: drop unnecessary comparison statement Austin Kim
2019-09-10 11:17 ` Austin Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADLLry4CjS+1syBCf68BFUbWxZJ8UGcUphinE1Hs7FRvdK0ikg@mail.gmail.com \
    --to=austindh.kim@gmail.com \
    --cc=aacraid@microsemi.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).