From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A920BC11F68 for ; Tue, 29 Jun 2021 22:41:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 88B1161C71 for ; Tue, 29 Jun 2021 22:41:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235460AbhF2Wnd (ORCPT ); Tue, 29 Jun 2021 18:43:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235149AbhF2Wna (ORCPT ); Tue, 29 Jun 2021 18:43:30 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3A3AC061760; Tue, 29 Jun 2021 15:41:01 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id x16so571716pfa.13; Tue, 29 Jun 2021 15:41:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=P+tvoezemK7sRfCs8ijjTjFf88uwIw3vayGLLc42vlI=; b=SIfctPZHI0xI5w5+zG5kXj3dKKDp2neIvQdMyhAIrxHZXJeLEsrh0xzaDiku+igNwJ SjlGSRLIyEs5ZY/qGXYqtYEpj6QBL0s4+BGoDiXJhSoxm8jghFxx8ET+DlyOzg08EigO Jw+jFzIdtl8qZtM8kobz/M5oQ8pwTqWaNgFYwWWSYAhcIxfwvrds68VEUP2LWaKdpi9p uE1FLvgQLkswsNkfS7vAoNPkdjUUosPotUUFAqn0hkBhpGP49VO7Eo+y52hlQtvt24R6 5Sx7nguXSiGxnqN+hZLt05msZgmxDPdLOxxsDj1XhMj5H3/6k7qhU2GJYgOhOHne1pcJ z1Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=P+tvoezemK7sRfCs8ijjTjFf88uwIw3vayGLLc42vlI=; b=C3Ovujr7d3evmi9uduV/g07evZujxIheNOxZKWQ699dPMVXgVFn2GtltdruKY/qqs7 Hlh4ClIIZCAuaITGc4hzuGdkehIsqubgY3oWcbJQB0un+CT8czTlLtAxs8DfizKX5Evg EkRlOAreDaX5qZphYzLIEKvnEFSMexUu1DRQN+vxi/6o35Tt13VBzREMu5kPI1D/HINF nghJ2y/detaWdF45g07NRy27TDonoAYCL1BNCZYKz7HVzKXoorGTRrSIHRZzrprOSNxQ EwwWt/Woh6r5aNBiHHLpIDC6E3pMysRUJ8ZjnQYsELXsO0oeaZe75SXM/maNpWxh2LB1 66qw== X-Gm-Message-State: AOAM532EcdrVqZaXOtfpE/WSkf1B1xyX+jmkooYrGMDo9lj3DMqqxtBu LUBci141Uu3KfOejs8ogZjqUsfekK5YsGijs6KM= X-Google-Smtp-Source: ABdhPJxIl8Vocc3Fb9/z6Xj8wolKdcTBXZA1v0f0l4OzmpcqdqRIIrAGt9qZj79bYAaxmwTKdGIhxyX3PrjKOPIhmrQ= X-Received: by 2002:a63:7d5:: with SMTP id 204mr4414226pgh.309.1625006461498; Tue, 29 Jun 2021 15:41:01 -0700 (PDT) MIME-Version: 1.0 References: <20210629135050.GA1373@raspberrypi> In-Reply-To: From: Austin Kim Date: Wed, 30 Jun 2021 07:40:50 +0900 Message-ID: Subject: Re: [PATCH] IMA: remove -Wmissing-prototypes warning To: Mimi Zohar Cc: dmitry.kasatkin@gmail.com, James Morris , "Serge E. Hallyn" , linux-integrity@vger.kernel.org, linux-security-module , Linux Kernel Mailing List , =?UTF-8?B?6rmA64+Z7ZiE?= , Petko Manolov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2021=EB=85=84 6=EC=9B=94 29=EC=9D=BC (=ED=99=94) =EC=98=A4=ED=9B=84 11:30, = Mimi Zohar =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > [Cc: Petko Manolov ] > > Hi Austin, > > On Tue, 2021-06-29 at 14:50 +0100, Austin Kim wrote: > > From: Austin Kim > > > > With W=3D1 build, the compiler throws warning message as below: > > > > security/integrity/ima/ima_mok.c:24:12: warning: > > no previous prototype for =E2=80=98ima_mok_init=E2=80=99 [-Wmissing-= prototypes] > > __init int ima_mok_init(void) > > > > Silence the warning by adding static keyword to ima_mok_init(). > > > > Signed-off-by: Austin Kim > > --- > > security/integrity/ima/ima_mok.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/security/integrity/ima/ima_mok.c b/security/integrity/ima/= ima_mok.c > > index 1e5c01916173..95cc31525c57 100644 > > --- a/security/integrity/ima/ima_mok.c > > +++ b/security/integrity/ima/ima_mok.c > > @@ -21,7 +21,7 @@ struct key *ima_blacklist_keyring; > > /* > > * Allocate the IMA blacklist keyring > > */ > > -__init int ima_mok_init(void) > > +static __init int ima_mok_init(void) > > { > > struct key_restriction *restriction; > > > > Thank you for the patch, which does fix the warning. The .ima_mok > keyring was removed a while ago. With all the recent work on the > system blacklist, I'm wondering if anyone is still using the IMA > blacklist keyring or whether it should be removed as well. Oh! Thanks for information. > > thanks, > > Mimi >