From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A556C56202 for ; Mon, 26 Oct 2020 15:19:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56F88223AB for ; Mon, 26 Oct 2020 15:19:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="srN5VM0T" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1783715AbgJZPTw (ORCPT ); Mon, 26 Oct 2020 11:19:52 -0400 Received: from mail-ej1-f66.google.com ([209.85.218.66]:33082 "EHLO mail-ej1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1783347AbgJZPTv (ORCPT ); Mon, 26 Oct 2020 11:19:51 -0400 Received: by mail-ej1-f66.google.com with SMTP id c15so14178640ejs.0; Mon, 26 Oct 2020 08:19:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UVCULFh/HSUomtNcBIFR0JMZ7sMmUjhTNpFI+1qIyFQ=; b=srN5VM0TT2gcHKYehOQsyh/wiLk/7rh6a6UAwl5rYNz8T8i8iTsJSMH8RqWN8nWfFA pHMbR459cGMtc5NXZRW4v62BZl7zEr8a1x8fJOpUZS1akonSzaHuXxjxn9+kYIg4wu7h hABUGo3EjYYCNCdVvjjrtRFxua3vuxnYC2D0Q6rwXOEkR6+6+uBpqaZJuKFBcTpXjGdR nQn+tFA4C1+lmsO8UhVWrPzoNwAGqSBQj3fQJHkKR1sNKowYbASKv9RI85Zqx5lHj0jk yJGS5B9PEXAIRWef5cU8dsX6DSzmrknvAsD0AnS12r6tJKAzGfv4RCtoogDG0lZWMLLX kQXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UVCULFh/HSUomtNcBIFR0JMZ7sMmUjhTNpFI+1qIyFQ=; b=IA7tiKShsQ0wFQ6P4P3KsHfoPQzKvRr9+wAXXczrWFOwXtgYlyj9DZ6bWRpbgyduC2 ueMu9dePt23aMTFKD1TIkSAzKQU0bmWT4XTg9HJ5K7miHmRgsikTSJSOIBocLUoOSoaT cxx97KF8e4PmTgi/rYOrxSLLf0HsnChFdImgMgU3CYpKI/YXVWkdUDAApWQzU+/ZclZK qNnOHXQDAi5xPy9xWL6sUFhEN9TrnPyfKBkQaUB6MEtt35RqyMgLU89DrngjLX/VkGg3 KObiwnmndCgQ2Wzsj0e0etoNbnwVHafMsenz+NW6cbHYsGrfVjrJfDfE4ZkjEk3WCbtV dymw== X-Gm-Message-State: AOAM530btNtGLRb3B8uXCThCaUcxXD5doUSXCAd6pj0YFk+dAYcTISbY Y5r2jO5HnOITFbgWI7Kr+bOKA3shxSKOkhrPx4Y= X-Google-Smtp-Source: ABdhPJxz32SJlXbJzg1AvE3KciOuVRJCIGRb970HxJSINrxzNG5+n4Glj6b28kxu4+056TYmISLJNAvPhkH16cUVLTg= X-Received: by 2002:a17:906:564d:: with SMTP id v13mr16878992ejr.217.1603725587392; Mon, 26 Oct 2020 08:19:47 -0700 (PDT) MIME-Version: 1.0 References: <20201017052057.2698588-1-bjorn.andersson@linaro.org> <20201017052057.2698588-3-bjorn.andersson@linaro.org> <20201026082732.GB8884@duo.ucw.cz> <20201026151105.GB10480@duo.ucw.cz> In-Reply-To: <20201026151105.GB10480@duo.ucw.cz> From: Martin Botka Date: Mon, 26 Oct 2020 16:19:36 +0100 Message-ID: Subject: Re: [PATCH v5 2/4] leds: Add driver for Qualcomm LPG To: Pavel Machek Cc: Bjorn Andersson , Dan Murphy , Rob Herring , Andy Gross , Thierry Reding , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Lee Jones , Linux LED Subsystem , devicetree , Linux Kernel Mailing List , linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > I was trying to use obviously bogus numbers to make you to specify > which patches you reviewed :-). Ahhhh now that makes much more sense. I reviewed patch 2. Tho from the quick look i dont see anything wrong with the DTS changes either.