From: Vitor Massaru Iha <vitor@massaru.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ian Rogers <irogers@google.com>,
Brendan Higgins <brendanhiggins@google.com>,
KUnit Development <kunit-dev@googlegroups.com>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] lib: kunit: add test_min_heap test conversion to KUnit
Date: Wed, 14 Oct 2020 17:03:52 -0300 [thread overview]
Message-ID: <CADQ6JjX+Hqw7Lm61BfMHrELya81boaYRrYmGH-o8xTBAgD_KSA@mail.gmail.com> (raw)
In-Reply-To: <20201014195948.GE2974@worktop.programming.kicks-ass.net>
On Wed, Oct 14, 2020 at 5:00 PM Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Wed, Oct 14, 2020 at 11:16:10AM -0700, Ian Rogers wrote:
>
> > There were some issues in the original patch, they should be easy to
> > fix. I'm more concerned that Peter's issues are addressed about the
> > general direction of the patch, verbosity and testing frameworks. I
> > see Vitor followed up with Peter but I'm not sure that means the
> > approach has been accepted.
>
> I kinda lost track, as long as it doesn't get more verbose I suppose I'm
> fine.
Ok. I'll send the v2 later with Ian's suggestions.
next prev parent reply other threads:[~2020-10-14 20:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 20:11 [PATCH] lib: kunit: add test_min_heap test conversion to KUnit Vitor Massaru Iha
2020-07-29 20:39 ` peterz
2020-07-29 21:57 ` Vitor Massaru Iha
2020-08-04 13:25 ` peterz
2020-08-04 13:46 ` Vitor Massaru Iha
2020-08-04 14:23 ` peterz
2020-08-04 16:22 ` Vitor Massaru Iha
2020-10-12 21:02 ` Brendan Higgins
2020-10-14 18:16 ` Ian Rogers
2020-10-14 19:59 ` Peter Zijlstra
2020-10-14 20:03 ` Vitor Massaru Iha [this message]
2020-07-29 22:56 ` Ian Rogers
2020-07-29 23:12 ` Vitor Massaru Iha
2020-10-14 23:49 ` Vitor Massaru Iha
2020-10-15 16:30 ` Ian Rogers
2020-10-15 16:56 ` Vitor Massaru Iha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADQ6JjX+Hqw7Lm61BfMHrELya81boaYRrYmGH-o8xTBAgD_KSA@mail.gmail.com \
--to=vitor@massaru.org \
--cc=brendanhiggins@google.com \
--cc=irogers@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).