From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751890AbcG1VxY (ORCPT ); Thu, 28 Jul 2016 17:53:24 -0400 Received: from mail-it0-f43.google.com ([209.85.214.43]:35477 "EHLO mail-it0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751377AbcG1VxW (ORCPT ); Thu, 28 Jul 2016 17:53:22 -0400 MIME-Version: 1.0 In-Reply-To: <1469628643-29661-1-git-send-email-wxt@rock-chips.com> References: <1469628643-29661-1-git-send-email-wxt@rock-chips.com> From: Stephen Barber Date: Thu, 28 Jul 2016 14:53:02 -0700 X-Google-Sender-Auth: qmNO0LQ9SNahtF2MEZRFgPfMdAM Message-ID: Subject: Re: [PATCH 1/2] thermal: rockchip: enhance the tsadc's bandgap feature for rk3399 To: Caesar Wang Cc: Eduardo Valentin , Douglas Anderson , Brian Norris , Rocky Hao , Zhang Rui , Heiko Stuebner , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 27, 2016 at 7:10 AM, Caesar Wang wrote: > From: Rocky Hao > > Due to the voltage ripple, the sensing data of the tsadc is not accurate. > And in this patch, the bandgap feature is enhanced to remove the voltage > ripple, and then the tsadc can sense the temperature more precisely. > > Obsolete codes are removed as well. > > Signed-off-by: Rocky Hao > Signed-off-by: Caesar Wang > Cc: Eduardo Valentin > Cc: Zhang Rui > Cc: Heiko Stuebner > Cc: linux-pm@vger.kernel.org > --- > > drivers/thermal/rockchip_thermal.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c > index db5ecc5..a90423d 100644 > --- a/drivers/thermal/rockchip_thermal.c > +++ b/drivers/thermal/rockchip_thermal.c > @@ -222,10 +222,10 @@ struct rockchip_thermal_data { > #define GRF_TSADC_TESTBIT_L 0x0e648 > #define GRF_TSADC_TESTBIT_H 0x0e64c > > -#define GRF_TSADC_TSEN_PD_ON (0x30003 << 0) > -#define GRF_TSADC_TSEN_PD_OFF (0x30000 << 0) > #define GRF_SARADC_TESTBIT_ON (0x10001 << 2) > #define GRF_TSADC_TESTBIT_H_ON (0x10001 << 2) > +#define GRF_TSADC_VCM_EN_L (0x10001 << 7) > +#define GRF_TSADC_VCM_EN_H (0x10001 << 7) > > /** > * struct tsadc_table - code to temperature conversion table > @@ -567,9 +567,10 @@ static void rk_tsadcv3_initialize(struct regmap *grf, void __iomem *regs, > regs + TSADCV2_HIGHT_TSHUT_DEBOUNCE); > > } else { > - regmap_write(grf, GRF_TSADC_TESTBIT_L, GRF_TSADC_TSEN_PD_ON); > - mdelay(10); > - regmap_write(grf, GRF_TSADC_TESTBIT_L, GRF_TSADC_TSEN_PD_OFF); > + /* Enable the voltage common mode feature */ > + regmap_write(grf, GRF_TSADC_TESTBIT_L, GRF_TSADC_VCM_EN_L); > + regmap_write(grf, GRF_TSADC_TESTBIT_H, GRF_TSADC_VCM_EN_H); > + > usleep_range(15, 100); /* The spec note says at least 15 us */ > regmap_write(grf, GRF_SARADC_TESTBIT, GRF_SARADC_TESTBIT_ON); > regmap_write(grf, GRF_TSADC_TESTBIT_H, GRF_TSADC_TESTBIT_H_ON); > -- > 1.9.1 > Tested-by: Stephen Barber Steve