From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751946AbcG1Vxu (ORCPT ); Thu, 28 Jul 2016 17:53:50 -0400 Received: from mail-it0-f51.google.com ([209.85.214.51]:35627 "EHLO mail-it0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751433AbcG1Vxs (ORCPT ); Thu, 28 Jul 2016 17:53:48 -0400 MIME-Version: 1.0 In-Reply-To: <1469628643-29661-2-git-send-email-wxt@rock-chips.com> References: <1469628643-29661-1-git-send-email-wxt@rock-chips.com> <1469628643-29661-2-git-send-email-wxt@rock-chips.com> From: Stephen Barber Date: Thu, 28 Jul 2016 14:53:28 -0700 X-Google-Sender-Auth: aqT2zDM3xkDQdzW2nzFA9nu4zrA Message-ID: Subject: Re: [PATCH 2/2] thermal: rockchip: optimize sensor auto accessing period To: Caesar Wang Cc: Eduardo Valentin , Douglas Anderson , Brian Norris , Rocky Hao , Zhang Rui , Heiko Stuebner , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 27, 2016 at 7:10 AM, Caesar Wang wrote: > From: Rocky Hao > > In less than 10 ms, the temperature of soc will arise 10 degree. 250 ms > is too big for soc tempeture control. Setting 2.5 ms will speed up > temperature accessing speed but introduce no more cpu's computing overhead. > We set AUTO_PERIOD_TIME and TSADCV3_AUTO_PERIOD_HT_TIME the same value, > because normal temperature update speed is also our consern in IPA. > > Signed-off-by: Rocky Hao > Signed-off-by: Caesar Wang > Cc: Zhang Rui > Cc: Eduardo Valentin > Cc: Heiko Stuebner > Cc: linux-pm@vger.kernel.org > > --- > > drivers/thermal/rockchip_thermal.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c > index a90423d..1f165c9 100644 > --- a/drivers/thermal/rockchip_thermal.c > +++ b/drivers/thermal/rockchip_thermal.c > @@ -213,8 +213,8 @@ struct rockchip_thermal_data { > #define TSADCV2_HIGHT_TSHUT_DEBOUNCE_COUNT 4 > #define TSADCV2_AUTO_PERIOD_TIME 250 /* 250ms */ > #define TSADCV2_AUTO_PERIOD_HT_TIME 50 /* 50ms */ > -#define TSADCV3_AUTO_PERIOD_TIME 187500 /* 250ms */ > -#define TSADCV3_AUTO_PERIOD_HT_TIME 37500 /* 50ms */ > +#define TSADCV3_AUTO_PERIOD_TIME 1875 /* 2.5ms */ > +#define TSADCV3_AUTO_PERIOD_HT_TIME 1875 /* 2.5ms */ > > #define TSADCV2_USER_INTER_PD_SOC 0x340 /* 13 clocks */ > > -- > 1.9.1 > Tested-by: Stephen Barber Steve