From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA7BDC433E1 for ; Fri, 22 May 2020 19:20:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5D01207DA for ; Fri, 22 May 2020 19:20:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730933AbgEVTUy (ORCPT ); Fri, 22 May 2020 15:20:54 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:41642 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730918AbgEVTUy (ORCPT ); Fri, 22 May 2020 15:20:54 -0400 Received: by mail-io1-f66.google.com with SMTP id o5so12498144iow.8; Fri, 22 May 2020 12:20:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7QXy8aTnpYj4ZL7eavU1d7UIYAYQxy4JmDn6cV7LhWI=; b=mEtXV42qyBjhNsnaU1UxvE7G1gGzrAmXJw2Ok8O5ILDom3s0+oTBnDBcF2M6Knx0Gq znYoB4lj3ORQ5iQu5EaU6aXulLQJZz6vdKMDAR0nYUbLpo6bVSQKl+AY5tiMle4JD+rr H7jTX9wSzEA4wjIoUdP0RTM0vgnWpy0urXEQn+elz3KaIiAMPXY88hv3sUBAhu3d6/I5 x29hlgWkSx2zLt2AkPq6nP/GHE68X14z1gSi6D4abccJ5pf1jsOciNp17ZWjBaa1URWI Oj+3/g1UBlbCWU3cQUhNSvA9rLb8qEzNkW/pjimHyRWQVclB8SzkfiFT8d7685nYGKlq swrg== X-Gm-Message-State: AOAM533eZvsMQ/p++By3Y/4U5g0s0cW47Zwj5sxyLXlVNgtO/3FM08GT +cx1W9npsCoZ7IOnlKcE78PcyhgP X-Google-Smtp-Source: ABdhPJy9G8HDq1MG+PtjijzcbP0Rf4PMRzTlR1T9vKVItNb892mHM53dTnWl1h6J6PcQ3Rogm5y3nQ== X-Received: by 2002:a5d:91d2:: with SMTP id k18mr3353534ior.20.1590175252552; Fri, 22 May 2020 12:20:52 -0700 (PDT) Received: from mail-il1-f182.google.com (mail-il1-f182.google.com. [209.85.166.182]) by smtp.gmail.com with ESMTPSA id p7sm4000986iob.7.2020.05.22.12.20.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 May 2020 12:20:52 -0700 (PDT) Received: by mail-il1-f182.google.com with SMTP id r2so553364ila.4; Fri, 22 May 2020 12:20:51 -0700 (PDT) X-Received: by 2002:a92:de02:: with SMTP id x2mr15117816ilm.267.1590175251164; Fri, 22 May 2020 12:20:51 -0700 (PDT) MIME-Version: 1.0 References: <20200520091543.44692-1-biwen.li@oss.nxp.com> In-Reply-To: <20200520091543.44692-1-biwen.li@oss.nxp.com> From: Li Yang Date: Fri, 22 May 2020 14:20:28 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [v2 1/2] dts: ppc: t4240rdb: remove interrupts property To: Biwen Li Cc: Rob Herring , Michael Ellerman , Benjamin Herrenschmidt , a.zummo@towertech.it, Alexandre Belloni , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linuxppc-dev , lkml , linux-rtc@vger.kernel.org, Biwen Li Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 20, 2020 at 4:21 AM Biwen Li wrote: > > From: Biwen Li > > This removes interrupts property to drop warning as follows: > - $ hwclock.util-linux > hwclock.util-linux: select() to /dev/rtc0 > to wait for clock tick timed out > > My case: > - RTC ds1374's INT pin is connected to VCC on T4240RDB, > then the RTC cannot inform cpu about the alarm interrupt The commit message need a little bit improvement. Something like: Since the interrupt pin for RTC DS1374 is not connected to the CPU on T4240RDB, remove the interrupt property from the device tree. This also fix the following warning for hwclock.util-linux: $ hwclock.util-linux hwclock.util-linux: select() to /dev/rtc0 to wait for clock tick timed out > > Signed-off-by: Biwen Li > --- > arch/powerpc/boot/dts/fsl/t4240rdb.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/powerpc/boot/dts/fsl/t4240rdb.dts b/arch/powerpc/boot/dts/fsl/t4240rdb.dts > index a56a705d41f7..145896f2eef6 100644 > --- a/arch/powerpc/boot/dts/fsl/t4240rdb.dts > +++ b/arch/powerpc/boot/dts/fsl/t4240rdb.dts > @@ -144,7 +144,6 @@ > rtc@68 { > compatible = "dallas,ds1374"; > reg = <0x68>; > - interrupts = <0x1 0x1 0 0>; > }; > }; > > -- > 2.17.1 >