linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yang Li <pku.leo@gmail.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: "Herbert Xu" <herbert@gondor.apana.org.au>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Horia Geantă" <horia.geanta@nxp.com>,
	"Cory Tusar" <cory.tusar@zii.aero>,
	"Chris Healy" <cphealy@gmail.com>,
	"Lucas Stach" <l.stach@pengutronix.de>,
	"Iuliana Prodan" <iuliana.prodan@nxp.com>,
	linux-crypto@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: imx8mq: Add CAAM node
Date: Tue, 10 Sep 2019 11:54:25 +0100	[thread overview]
Message-ID: <CADRPPNSRv-WLCbhWmmbsyjaUD0v-_Au8utXDy1z8gx45TnwDwQ@mail.gmail.com> (raw)
In-Reply-To: <20190830210139.7028-1-andrew.smirnov@gmail.com>

On Fri, Aug 30, 2019 at 10:05 PM Andrey Smirnov
<andrew.smirnov@gmail.com> wrote:
>
> Add node for CAAM - Cryptographic Acceleration and Assurance Module.
>
> Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>

The patch itself looks good to me.

Acked-by: Li Yang <leoyang.li@nxp.com>

> Cc: Cory Tusar <cory.tusar@zii.aero>
> Cc: Chris Healy <cphealy@gmail.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Iuliana Prodan <iuliana.prodan@nxp.com>
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
>
> Shawn:
>
> Just a bit of a context: as per this thread
> https://lore.kernel.org/linux-crypto/20190830131547.GA27480@gondor.apana.org.au/
> I am hoping I can get and Ack from you for this patch, so it can go
> via cryptodev tree.

The dts is describing the hardware and normally update to it shouldn't
break old drivers.  Not sure if this time the dts change is depending
on driver change again?   I remember previously arm-soc maintainer
prefer to have dts changes merged with soc trees as a common practice.

Regards,
Leo

>
> Thanks,
> Andrey Smirnov
>
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 30 +++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index d09b808eff87..752d5a61878c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -728,6 +728,36 @@
>                                 status = "disabled";
>                         };
>
> +                       crypto: crypto@30900000 {
> +                               compatible = "fsl,sec-v4.0";
> +                               #address-cells = <1>;
> +                               #size-cells = <1>;
> +                               reg = <0x30900000 0x40000>;
> +                               ranges = <0 0x30900000 0x40000>;
> +                               interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
> +                               clocks = <&clk IMX8MQ_CLK_AHB>,
> +                                        <&clk IMX8MQ_CLK_IPG_ROOT>;
> +                               clock-names = "aclk", "ipg";
> +
> +                               sec_jr0: jr@1000 {
> +                                       compatible = "fsl,sec-v4.0-job-ring";
> +                                       reg = <0x1000 0x1000>;
> +                                       interrupts = <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>;
> +                               };
> +
> +                               sec_jr1: jr@2000 {
> +                                       compatible = "fsl,sec-v4.0-job-ring";
> +                                       reg = <0x2000 0x1000>;
> +                                       interrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>;
> +                               };
> +
> +                               sec_jr2: jr@3000 {
> +                                       compatible = "fsl,sec-v4.0-job-ring";
> +                                       reg = <0x3000 0x1000>;
> +                                       interrupts = <GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH>;
> +                               };
> +                       };
> +
>                         i2c1: i2c@30a20000 {
>                                 compatible = "fsl,imx8mq-i2c", "fsl,imx21-i2c";
>                                 reg = <0x30a20000 0x10000>;
> --
> 2.21.0
>


-- 
- Leo

  parent reply	other threads:[~2019-09-10 10:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-30 21:01 Andrey Smirnov
2019-09-06 10:36 ` Horia Geanta
2019-09-10 10:54 ` Yang Li [this message]
2019-09-13 11:28 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADRPPNSRv-WLCbhWmmbsyjaUD0v-_Au8utXDy1z8gx45TnwDwQ@mail.gmail.com \
    --to=pku.leo@gmail.com \
    --cc=andrew.smirnov@gmail.com \
    --cc=cory.tusar@zii.aero \
    --cc=cphealy@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=horia.geanta@nxp.com \
    --cc=iuliana.prodan@nxp.com \
    --cc=l.stach@pengutronix.de \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shawnguo@kernel.org \
    --subject='Re: [PATCH] arm64: dts: imx8mq: Add CAAM node' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).