Re: mm/hugetlb.c:5580:3: error: implicit declaration of function 'for_each_mem_pfn_range'; did you mean 'for_each_mem_range'

From: Yang Li <pku.leo@gmail.com>
To: Roman Gushchin <guro@fb.com>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	open list <linux-kernel@vger.kernel.org>,
	andreas.schaufler@gmx.de,
	"Kirill A. Shutemov" <kirill@shutemov.name>,
	Mike Kravetz <mike.kravetz@oracle.com>,
	Michal Hocko <mhocko@kernel.org>, Rik van Riel <riel@surriel.com>,
	js1304@gmail.com, lkft-triage@lists.linaro.org
Subject: Re: mm/hugetlb.c:5580:3: error: implicit declaration of function 'for_each_mem_pfn_range'; did you mean 'for_each_mem_range'
Date: Thu, 9 Apr 2020 17:06:17 -0500	[thread overview]
Message-ID: <CADRPPNTSOJsz3kihZ3vXK0i6zWpUY_C36GxqmMO6ehACPT=aBg@mail.gmail.com> (raw)
In-Reply-To: <20200406172525.GA338360@carbon.DHCP.thefacebook.com>

On Mon, Apr 6, 2020 at 12:37 PM Roman Gushchin <guro@fb.com> wrote:
>
> On Mon, Apr 06, 2020 at 07:48:54PM +0530, Naresh Kamboju wrote:
> > While building Linux-next master for arm beagle board x15 the following
> > build error was noticed.
>
> Hello Naresh!
>
> There was a number of cleanups and fixes to the original hugetlb_cma
> patch, and it looks like some parts were lost.
> I'm going to gather all changes and resubmit a new version later today.
> Sorry for the inconvenience.

Hi Roman,

I'm still getting this compile issue with linux-next tag
next-20200409.  If the current patch set is broken, can we remove them
from the linux-next for now?

Regards,
Leo
>
> Thanks!
>
> >
> > mm/hugetlb.c: In function 'hugetlb_cma_reserve':
> > mm/hugetlb.c:5580:3: error: implicit declaration of function
> > 'for_each_mem_pfn_range'; did you mean 'for_each_mem_range'?
> > [-Werror=implicit-function-declaration]
> >    for_each_mem_pfn_range(i, nid, &start_pfn, &end_pfn, NULL) {
> >    ^~~~~~~~~~~~~~~~~~~~~~
> >    for_each_mem_range
> > mm/hugetlb.c:5580:62: error: expected ';' before '{' token
> >    for_each_mem_pfn_range(i, nid, &start_pfn, &end_pfn, NULL) {
> >                                                               ^
> > Few more details about build test,
> >
> > CONFIG_HUGETLBFS=y
> > CONFIG_HUGETLB_PAGE=y
> > CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE=y
> > CONFIG_ARCH_WANT_HUGE_PMD_SHARE=y
> >
> > # CONFIG_TRANSPARENT_HUGEPAGE is not set
> > # CONFIG_CMA is not set
> >
> > Kernel config link,
> > https://urldefense.proofpoint.com/v2/url?u=http-3A__snapshots.linaro.org_openembedded_lkft_lkft_sumo_intel-2Dcore2-2D32_lkft_linux-2Dmainline_2591_config&d=DwIBaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=jJYgtDM7QT-W-Fz_d29HYQ&m=UExtNmMVvgxP1D5SQnPuvrZmT1KYfONSBf9zENyfrs4&s=O436GE4UqAvqVk0stawAOhOUm1bNCFpZzxiVeNSs-ck&e=
> >
> > Build log,
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__ci.linaro.org_view_lkft_job_openembedded-2Dlkft-2Dlinux-2Dnext_DISTRO-3Dlkft-2CMACHINE-3Dam57xx-2Devm-2Clabel-3Ddocker-2Dlkft_743_consoleText&d=DwIBaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=jJYgtDM7QT-W-Fz_d29HYQ&m=UExtNmMVvgxP1D5SQnPuvrZmT1KYfONSBf9zENyfrs4&s=nuGZRu4xyY-99ohWh1uNDTo6NeV62n7kSsyoefxEGvI&e=
> >
> > --
> > Linaro LKFT
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__lkft.linaro.org&d=DwIBaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=jJYgtDM7QT-W-Fz_d29HYQ&m=UExtNmMVvgxP1D5SQnPuvrZmT1KYfONSBf9zENyfrs4&s=uYemxk7TXD2Qie6H7zY9UjuE7zlN5ILjbD_1UD3jo4A&e=

-- 
- Leo