From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757493Ab2IZQ6f (ORCPT ); Wed, 26 Sep 2012 12:58:35 -0400 Received: from mail-ie0-f174.google.com ([209.85.223.174]:47148 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757397Ab2IZQ6a (ORCPT ); Wed, 26 Sep 2012 12:58:30 -0400 MIME-Version: 1.0 In-Reply-To: <1348194419-11486-2-git-send-email-sboyd@codeaurora.org> References: <1348194419-11486-1-git-send-email-sboyd@codeaurora.org> <1348194419-11486-2-git-send-email-sboyd@codeaurora.org> Date: Wed, 26 Sep 2012 22:28:29 +0530 Message-ID: Subject: Re: [PATCH 01/10] usb: otg: msm: Convert to clk_prepare/unprepare From: Pankaj Jangra To: Stephen Boyd Cc: David Brown , Daniel Walker , Bryan Huntsman , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, Felipe Balbi Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi.. On Fri, Sep 21, 2012 at 7:56 AM, Stephen Boyd wrote: > Add calls to clk_prepare and unprepare so that MSM can migrate to > the common clock framework. > > Cc: Felipe Balbi > Signed-off-by: Stephen Boyd > --- > drivers/usb/otg/msm_otg.c | 38 +++++++++++++++++++------------------- > 1 file changed, 19 insertions(+), 19 deletions(-) > > diff --git a/drivers/usb/otg/msm_otg.c b/drivers/usb/otg/msm_otg.c > index 9f5fc90..2ae0639 100644 > --- a/drivers/usb/otg/msm_otg.c > +++ b/drivers/usb/otg/msm_otg.c > @@ -514,13 +514,13 @@ static int msm_otg_suspend(struct msm_otg *motg) > motg->pdata->otg_control == OTG_PMIC_CONTROL) > writel(readl(USB_PHY_CTRL) | PHY_RETEN, USB_PHY_CTRL); > > - clk_disable(motg->pclk); > - clk_disable(motg->clk); > + clk_disable_unprepare(motg->pclk); > + clk_disable_unprepare(motg->clk); > if (motg->core_clk) > - clk_disable(motg->core_clk); > + clk_disable_unprepare(motg->core_clk); > I was under assumption that system suspend/resume might be called from the interrupt context. If that is case then its not appropriate to call clk_prepare/unprepare here right? or my understanding is not correct???? -- Pankaj Jangra