From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFC7DC432BE for ; Mon, 26 Jul 2021 21:18:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B61A660F91 for ; Mon, 26 Jul 2021 21:18:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233422AbhGZUh5 (ORCPT ); Mon, 26 Jul 2021 16:37:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232788AbhGZUh4 (ORCPT ); Mon, 26 Jul 2021 16:37:56 -0400 Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CFDDC061757; Mon, 26 Jul 2021 14:18:24 -0700 (PDT) Received: by mail-yb1-xb35.google.com with SMTP id a93so17217080ybi.1; Mon, 26 Jul 2021 14:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MPfNRfZv4QlQu0N35iNOwu7avqCa/8bSd3bKlBcFimw=; b=l7wseu3GRTMOWEFS1N8EN/SvCgv52Uo8XRCgGLpfFJ0KC0NtpP2MoPvKHZxva/V+KK 80IdCIUqrNK20sgcHmTOAvDPY5hGxKZcByywGc3SIQctbmBVYnhK/YfzBA4mqJumhfnK c25zMSDO9rG9mlJmpCXvllpwDUbGOJN4f1vuZeduxSTSX1LRLboLnkeZUIXMC92vjluc /sU9WXlXNCnqReF1doE4z80gM0TMdqynkwnQNgIpOyg4ZR5nW374vU/tQ1ZYzPGw1GaW uu89QofHzTmZ8F9wkZ/vJ2VKibPi8YN/drUafvTnHVRk5QNwButph027BhSdNENhAcJK Z2bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MPfNRfZv4QlQu0N35iNOwu7avqCa/8bSd3bKlBcFimw=; b=eRiDnThHVn+fJm6gYJHYSpoYOLsDQB9rkGT72Aecexzybc3iM4PW/yggrNUntPJYLj W/jbx5Szs5SWkj+i7c4L5DgQQztKDR3NGcnO79/2R8eHL5LRvYdT5G2XsqLUJ1U2JKLb tLmMuYj7WRvl25fgJD1lLJw6II6zQdTODAI//Ivi0ltKkUsXxukqqV2ufTn2fBbWKTDW VXXSPEbLebHXnkng9uOlmsveR+fUWIj6XQ9iRNQc0YusIygCuMBAaeifKC7LZjy+6aLR kpGNBMYGnZ5z1bxpmTIxuJmkNyUZcK2p8hkLm42b9syr51Id1Hz6OARO13JYQHgEE1MD G6tg== X-Gm-Message-State: AOAM530eomJI3cEr2g/3Vo4b4jdOMt/PJOXpdoD4siPShAZzAgZAXwPA wyOMKwo3Q17MMZ5K21RePbB4cC78tsj7fThnb26bvLWYxQcIkQ== X-Google-Smtp-Source: ABdhPJxnLKnyqSCPE7NdMhnF1D9rLeXKWpLtQULHt7Js+WlgNfmTzrQoWTU2u/M/vi+egUCO8fgUBEZ5RHFATbXMPFo= X-Received: by 2002:a25:c402:: with SMTP id u2mr25127220ybf.19.1627334303666; Mon, 26 Jul 2021 14:18:23 -0700 (PDT) MIME-Version: 1.0 References: <20210726153832.339431936@linuxfoundation.org> <20210726153836.031515657@linuxfoundation.org> In-Reply-To: <20210726153836.031515657@linuxfoundation.org> From: Sudip Mukherjee Date: Mon, 26 Jul 2021 22:17:47 +0100 Message-ID: Subject: Re: [PATCH 4.19 111/120] KVM: do not assume PTE is writable after follow_pfn To: Greg Kroah-Hartman Cc: linux-kernel , Stable , David Stevens , 3pvd@google.com, Jann Horn , Jason Gunthorpe , Paolo Bonzini , Ovidiu Panait Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, On Mon, Jul 26, 2021 at 4:58 PM Greg Kroah-Hartman wrote: > > From: Paolo Bonzini > > commit bd2fae8da794b55bf2ac02632da3a151b10e664c upstream. The build of mips malta_kvm_defconfig fails with the error: In file included from arch/mips/kvm/../../../virt/kvm/kvm_main.c:21: arch/mips/kvm/../../../virt/kvm/kvm_main.c: In function 'hva_to_pfn_remapped': ./include/linux/kvm_host.h:70:33: error: conversion from 'long long unsigned int' to 'long unsigned int' changes value from '9218868437227405314' to '2' [-Werror=overflow] 70 | #define KVM_PFN_ERR_RO_FAULT (KVM_PFN_ERR_MASK + 2) | ^ arch/mips/kvm/../../../virt/kvm/kvm_main.c:1530:23: note: in expansion of macro 'KVM_PFN_ERR_RO_FAULT' 1530 | pfn = KVM_PFN_ERR_RO_FAULT; It built fine after reverting this patch. gcc version 11.1.1 20210723 -- Regards Sudip