linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: bing fan <hptsfb@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] arm pl011 serial: support multi-irq request
Date: Mon, 28 Jun 2021 15:19:13 +0800	[thread overview]
Message-ID: <CADVmyHWOVRNfVaJMm9D9KsFsi+t5cDwYtHcA9wn=v_Jh1QK-Rw@mail.gmail.com> (raw)

From: Bing Fan <tombinfan@tencent.com>

In order to make pl011 work better, multiple interrupts are
required, such as TXIM, RXIM, RTIM, error interrupt(FE/PE/BE/OE);
at the same time, pl011 to GIC does not merge the interrupt
lines(each serial-interrupt corresponding to different GIC hardware
interrupt), so need to enable and request multiple gic interrupt
numbers in the driver.

Signed-off-by: Bing Fan <hptsfb@gmail.com>
---
 drivers/tty/serial/amba-pl011.c | 23 ++++++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
index 78682c12156a..2b6f43c27dea 100644
--- a/drivers/tty/serial/amba-pl011.c
+++ b/drivers/tty/serial/amba-pl011.c
@@ -1703,9 +1703,30 @@ static void pl011_write_lcr_h(struct
uart_amba_port *uap, unsigned int lcr_h)

 static int pl011_allocate_irq(struct uart_amba_port *uap)
 {
+       int ret = -1;
+       int i = 0;
+       unsigned int virq = 0;
+       struct amba_device *amba_dev = (struct amba_device *)uap->port.dev;
+
+       if (!amba_dev)
+               return -1;
+
        pl011_write(uap->im, uap, REG_IMSC);

-       return request_irq(uap->port.irq, pl011_int, IRQF_SHARED,
"uart-pl011", uap);
+       for (i = 0; i < AMBA_NR_IRQS; i++) {
+               virq = amba_dev->irq[i];
+               if (virq == 0)          // request irq until virq is 0
+                       break;
+
+               ret = request_irq(virq, pl011_int, IRQF_SHARED,
"uart-pl011-*", uap);
+               if (ret < 0) {
+                       dev_info(uap->port.dev, "%s %d request %u
interrupt failed\n",
+                                       __func__, __LINE__, virq);
+                       break;
+               }
+       }
+
+       return ret;
 }

 /*
-- 
2.17.1

             reply	other threads:[~2021-06-28  7:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-28  7:19 bing fan [this message]
2021-06-28  8:48 ` [PATCH] arm pl011 serial: support multi-irq request Greg Kroah-Hartman
2021-06-29  1:29 Bing Fan
2021-06-29  6:18 ` Greg KH
     [not found]   ` <d2ba9f70-2ace-d796-8ce8-fd56d73d145b@gmail.com>
2021-06-29 12:18     ` Greg KH
     [not found]       ` <8e3133f8-a528-70fb-d539-9508a6cdcd3a@gmail.com>
2021-06-29 13:14         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADVmyHWOVRNfVaJMm9D9KsFsi+t5cDwYtHcA9wn=v_Jh1QK-Rw@mail.gmail.com' \
    --to=hptsfb@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).