* [PATCH] net/rds/Kconfig: RDS should depend on IPV6
@ 2018-07-25 22:20 Anders Roxell
2018-07-25 22:36 ` Santosh Shilimkar
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Anders Roxell @ 2018-07-25 22:20 UTC (permalink / raw)
To: davem, santosh.shilimkar, ka-cheong.poon
Cc: netdev, linux-rdma, rds-devel, linux-kernel, Anders Roxell
Build error, implicit declaration of function __inet6_ehashfn shows up
When RDS is enabled but not IPV6.
net/rds/connection.c: In function ‘rds_conn_bucket’:
net/rds/connection.c:67:9: error: implicit declaration of function ‘__inet6_ehashfn’; did you mean ‘__inet_ehashfn’? [-Werror=implicit-function-declaration]
hash = __inet6_ehashfn(lhash, 0, fhash, 0, rds_hash_secret);
^~~~~~~~~~~~~~~
__inet_ehashfn
Current code adds IPV6 as a depends on in config RDS.
Fixes: eee2fa6ab322 ("rds: Changing IP address internal representation to struct in6_addr")
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
net/rds/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/rds/Kconfig b/net/rds/Kconfig
index 41f75563b54b..607128f10bcd 100644
--- a/net/rds/Kconfig
+++ b/net/rds/Kconfig
@@ -1,7 +1,7 @@
config RDS
tristate "The RDS Protocol"
- depends on INET
+ depends on INET && CONFIG_IPV6
---help---
The RDS (Reliable Datagram Sockets) protocol provides reliable,
sequenced delivery of datagrams over Infiniband or TCP.
--
2.18.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] net/rds/Kconfig: RDS should depend on IPV6
2018-07-25 22:20 [PATCH] net/rds/Kconfig: RDS should depend on IPV6 Anders Roxell
@ 2018-07-25 22:36 ` Santosh Shilimkar
2018-07-26 4:56 ` Ka-Cheong Poon
2018-07-26 5:34 ` David Miller
2018-07-27 11:52 ` Eric Dumazet
2 siblings, 1 reply; 7+ messages in thread
From: Santosh Shilimkar @ 2018-07-25 22:36 UTC (permalink / raw)
To: Anders Roxell, ka-cheong.poon
Cc: davem, netdev, linux-rdma, rds-devel, linux-kernel
On 7/25/2018 3:20 PM, Anders Roxell wrote:
> Build error, implicit declaration of function __inet6_ehashfn shows up
> When RDS is enabled but not IPV6.
> net/rds/connection.c: In function ‘rds_conn_bucket’:
> net/rds/connection.c:67:9: error: implicit declaration of function ‘__inet6_ehashfn’; did you mean ‘__inet_ehashfn’? [-Werror=implicit-function-declaration]
> hash = __inet6_ehashfn(lhash, 0, fhash, 0, rds_hash_secret);
> ^~~~~~~~~~~~~~~
> __inet_ehashfn
>
> Current code adds IPV6 as a depends on in config RDS.
>
> Fixes: eee2fa6ab322 ("rds: Changing IP address internal representation to struct in6_addr")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> net/rds/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/rds/Kconfig b/net/rds/Kconfig
> index 41f75563b54b..607128f10bcd 100644
> --- a/net/rds/Kconfig
> +++ b/net/rds/Kconfig
> @@ -1,7 +1,7 @@
>
> config RDS
> tristate "The RDS Protocol"
> - depends on INET
> + depends on INET && CONFIG_IPV6
This should build without CONFIG_IPV6 too.
Hi Ka-cheong,
Can you please loot at it ? I know you modified
lookup function to take always in6_addr now, but
probably hashing with '__inet_ehashfn' should
work too for non IPV6 address(s).
Regards,
Santosh
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] net/rds/Kconfig: RDS should depend on IPV6
2018-07-25 22:36 ` Santosh Shilimkar
@ 2018-07-26 4:56 ` Ka-Cheong Poon
2018-07-26 5:02 ` santosh.shilimkar
0 siblings, 1 reply; 7+ messages in thread
From: Ka-Cheong Poon @ 2018-07-26 4:56 UTC (permalink / raw)
To: Santosh Shilimkar, Anders Roxell
Cc: davem, netdev, linux-rdma, rds-devel, linux-kernel
On 07/26/2018 06:36 AM, Santosh Shilimkar wrote:
> On 7/25/2018 3:20 PM, Anders Roxell wrote:
>> Build error, implicit declaration of function __inet6_ehashfn shows up
>> When RDS is enabled but not IPV6.
>> net/rds/connection.c: In function ‘rds_conn_bucket’:
>> net/rds/connection.c:67:9: error: implicit declaration of function
>> ‘__inet6_ehashfn’; did you mean ‘__inet_ehashfn’?
>> [-Werror=implicit-function-declaration]
>> hash = __inet6_ehashfn(lhash, 0, fhash, 0, rds_hash_secret);
>> ^~~~~~~~~~~~~~~
>> __inet_ehashfn
>>
>> Current code adds IPV6 as a depends on in config RDS.
>>
>> Fixes: eee2fa6ab322 ("rds: Changing IP address internal representation
>> to struct in6_addr")
>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>> ---
>> net/rds/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/rds/Kconfig b/net/rds/Kconfig
>> index 41f75563b54b..607128f10bcd 100644
>> --- a/net/rds/Kconfig
>> +++ b/net/rds/Kconfig
>> @@ -1,7 +1,7 @@
>> config RDS
>> tristate "The RDS Protocol"
>> - depends on INET
>> + depends on INET && CONFIG_IPV6
> This should build without CONFIG_IPV6 too.
>
> Hi Ka-cheong,
> Can you please loot at it ? I know you modified
> lookup function to take always in6_addr now, but
> probably hashing with '__inet_ehashfn' should
> work too for non IPV6 address(s).
I guess for now, let's add this dependency first. I
will do a follow up patch to remove this dependency.
Thanks.
--
K. Poon
ka-cheong.poon@oracle.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] net/rds/Kconfig: RDS should depend on IPV6
2018-07-26 4:56 ` Ka-Cheong Poon
@ 2018-07-26 5:02 ` santosh.shilimkar
0 siblings, 0 replies; 7+ messages in thread
From: santosh.shilimkar @ 2018-07-26 5:02 UTC (permalink / raw)
To: Ka-Cheong Poon, Anders Roxell
Cc: davem, netdev, linux-rdma, rds-devel, linux-kernel
On 7/25/18 9:56 PM, Ka-Cheong Poon wrote:
> On 07/26/2018 06:36 AM, Santosh Shilimkar wrote:
>> On 7/25/2018 3:20 PM, Anders Roxell wrote:
>>> Build error, implicit declaration of function __inet6_ehashfn shows up
>>> When RDS is enabled but not IPV6.
>>> net/rds/connection.c: In function ‘rds_conn_bucket’:
>>> net/rds/connection.c:67:9: error: implicit declaration of function
>>> ‘__inet6_ehashfn’; did you mean ‘__inet_ehashfn’?
>>> [-Werror=implicit-function-declaration]
>>> hash = __inet6_ehashfn(lhash, 0, fhash, 0, rds_hash_secret);
>>> ^~~~~~~~~~~~~~~
>>> __inet_ehashfn
>>>
>>> Current code adds IPV6 as a depends on in config RDS.
>>>
>>> Fixes: eee2fa6ab322 ("rds: Changing IP address internal
>>> representation to struct in6_addr")
>>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>>> --- >>> net/rds/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/net/rds/Kconfig b/net/rds/Kconfig
>>> index 41f75563b54b..607128f10bcd 100644
>>> --- a/net/rds/Kconfig
>>> +++ b/net/rds/Kconfig
>>> @@ -1,7 +1,7 @@
>>> config RDS
>>> tristate "The RDS Protocol"
>>> - depends on INET
>>> + depends on INET && CONFIG_IPV6
>> This should build without CONFIG_IPV6 too.
>>
>> Hi Ka-cheong,
>> Can you please loot at it ? I know you modified
>> lookup function to take always in6_addr now, but
>> probably hashing with '__inet_ehashfn' should
>> work too for non IPV6 address(s).
>
>
> I guess for now, let's add this dependency first. I
> will do a follow up patch to remove this dependency.
>
Sounds good to me.
FWIW,
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] net/rds/Kconfig: RDS should depend on IPV6
2018-07-25 22:20 [PATCH] net/rds/Kconfig: RDS should depend on IPV6 Anders Roxell
2018-07-25 22:36 ` Santosh Shilimkar
@ 2018-07-26 5:34 ` David Miller
2018-07-27 11:52 ` Eric Dumazet
2 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2018-07-26 5:34 UTC (permalink / raw)
To: anders.roxell
Cc: santosh.shilimkar, ka-cheong.poon, netdev, linux-rdma, rds-devel,
linux-kernel
From: Anders Roxell <anders.roxell@linaro.org>
Date: Thu, 26 Jul 2018 00:20:08 +0200
> Build error, implicit declaration of function __inet6_ehashfn shows up
> When RDS is enabled but not IPV6.
> net/rds/connection.c: In function ‘rds_conn_bucket’:
> net/rds/connection.c:67:9: error: implicit declaration of function ‘__inet6_ehashfn’; did you mean ‘__inet_ehashfn’? [-Werror=implicit-function-declaration]
> hash = __inet6_ehashfn(lhash, 0, fhash, 0, rds_hash_secret);
> ^~~~~~~~~~~~~~~
> __inet_ehashfn
>
> Current code adds IPV6 as a depends on in config RDS.
>
> Fixes: eee2fa6ab322 ("rds: Changing IP address internal representation to struct in6_addr")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Applied.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] net/rds/Kconfig: RDS should depend on IPV6
2018-07-25 22:20 [PATCH] net/rds/Kconfig: RDS should depend on IPV6 Anders Roxell
2018-07-25 22:36 ` Santosh Shilimkar
2018-07-26 5:34 ` David Miller
@ 2018-07-27 11:52 ` Eric Dumazet
2018-07-27 13:11 ` Anders Roxell
2 siblings, 1 reply; 7+ messages in thread
From: Eric Dumazet @ 2018-07-27 11:52 UTC (permalink / raw)
To: Anders Roxell, davem, santosh.shilimkar, ka-cheong.poon
Cc: netdev, linux-rdma, rds-devel, linux-kernel
On 07/25/2018 03:20 PM, Anders Roxell wrote:
> Build error, implicit declaration of function __inet6_ehashfn shows up
> When RDS is enabled but not IPV6.
> net/rds/connection.c: In function ‘rds_conn_bucket’:
> net/rds/connection.c:67:9: error: implicit declaration of function ‘__inet6_ehashfn’; did you mean ‘__inet_ehashfn’? [-Werror=implicit-function-declaration]
> hash = __inet6_ehashfn(lhash, 0, fhash, 0, rds_hash_secret);
> ^~~~~~~~~~~~~~~
> __inet_ehashfn
>
> Current code adds IPV6 as a depends on in config RDS.
>
> Fixes: eee2fa6ab322 ("rds: Changing IP address internal representation to struct in6_addr")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> net/rds/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/rds/Kconfig b/net/rds/Kconfig
> index 41f75563b54b..607128f10bcd 100644
> --- a/net/rds/Kconfig
> +++ b/net/rds/Kconfig
> @@ -1,7 +1,7 @@
>
> config RDS
> tristate "The RDS Protocol"
> - depends on INET
> + depends on INET && CONFIG_IPV6
You probably meant :
depends on INET && IPV6
> ---help---
> The RDS (Reliable Datagram Sockets) protocol provides reliable,
> sequenced delivery of datagrams over Infiniband or TCP.
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] net/rds/Kconfig: RDS should depend on IPV6
2018-07-27 11:52 ` Eric Dumazet
@ 2018-07-27 13:11 ` Anders Roxell
0 siblings, 0 replies; 7+ messages in thread
From: Anders Roxell @ 2018-07-27 13:11 UTC (permalink / raw)
To: eric.dumazet
Cc: David Miller, Santosh Shilimkar, ka-cheong.poon, Networking,
linux-rdma, rds-devel, Linux Kernel Mailing List
On Fri, 27 Jul 2018 at 13:52, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
>
>
> On 07/25/2018 03:20 PM, Anders Roxell wrote:
> > Build error, implicit declaration of function __inet6_ehashfn shows up
> > When RDS is enabled but not IPV6.
> > net/rds/connection.c: In function ‘rds_conn_bucket’:
> > net/rds/connection.c:67:9: error: implicit declaration of function ‘__inet6_ehashfn’; did you mean ‘__inet_ehashfn’? [-Werror=implicit-function-declaration]
> > hash = __inet6_ehashfn(lhash, 0, fhash, 0, rds_hash_secret);
> > ^~~~~~~~~~~~~~~
> > __inet_ehashfn
> >
> > Current code adds IPV6 as a depends on in config RDS.
> >
> > Fixes: eee2fa6ab322 ("rds: Changing IP address internal representation to struct in6_addr")
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > ---
> > net/rds/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/rds/Kconfig b/net/rds/Kconfig
> > index 41f75563b54b..607128f10bcd 100644
> > --- a/net/rds/Kconfig
> > +++ b/net/rds/Kconfig
> > @@ -1,7 +1,7 @@
> >
> > config RDS
> > tristate "The RDS Protocol"
> > - depends on INET
> > + depends on INET && CONFIG_IPV6
>
> You probably meant :
>
> depends on INET && IPV6
Hmm... Yes, I'll send out a new patch to fix it.
I'm sorry.
Cheers,
Anders
>
>
> > ---help---
> > The RDS (Reliable Datagram Sockets) protocol provides reliable,
> > sequenced delivery of datagrams over Infiniband or TCP.
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-07-27 13:11 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-25 22:20 [PATCH] net/rds/Kconfig: RDS should depend on IPV6 Anders Roxell
2018-07-25 22:36 ` Santosh Shilimkar
2018-07-26 4:56 ` Ka-Cheong Poon
2018-07-26 5:02 ` santosh.shilimkar
2018-07-26 5:34 ` David Miller
2018-07-27 11:52 ` Eric Dumazet
2018-07-27 13:11 ` Anders Roxell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).