From: Anders Roxell <anders.roxell@linaro.org>
To: David Miller <davem@davemloft.net>, Shuah Khan <shuah@kernel.org>
Cc: "open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] selftests/networking: remove timestamping clean target
Date: Thu, 31 Jan 2019 20:07:02 +0100 [thread overview]
Message-ID: <CADYN=9JAogKRqz7jwKgFZvEMqJNo8QT2aJVuJ0jqB+Ce_g6J1Q@mail.gmail.com> (raw)
In-Reply-To: <20190108092525.12817-1-anders.roxell@linaro.org>
On Tue, 8 Jan 2019 at 10:25, Anders Roxell <anders.roxell@linaro.org> wrote:
>
> Commit cda261f421ba ("selftests: add txtimestamp kselftest") introduced
> a warning:
>
> Makefile:14: warning: overriding recipe for target 'clean'
> ../../lib.mk:137: warning: ignoring old recipe for target 'clean'
>
> Theres no need for timestamping to have its own 'clean' target. The
> lib.mk file's 'clean' target gets included to the timestamping Makefile
> and that should be enough.
>
> Fixes: cda261f421ba ("selftests: add txtimestamp kselftest")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> tools/testing/selftests/networking/timestamping/Makefile | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tools/testing/selftests/networking/timestamping/Makefile b/tools/testing/selftests/networking/timestamping/Makefile
> index 9050eeea5f5f..1de8bd8ccf5d 100644
> --- a/tools/testing/selftests/networking/timestamping/Makefile
> +++ b/tools/testing/selftests/networking/timestamping/Makefile
> @@ -9,6 +9,3 @@ all: $(TEST_PROGS)
> top_srcdir = ../../../../..
> KSFT_KHDR_INSTALL := 1
> include ../../lib.mk
> -
> -clean:
> - rm -fr $(TEST_GEN_FILES)
> --
> 2.20.1
>
Does this make sense?
Cheers,
Anders
prev parent reply other threads:[~2019-01-31 19:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 9:25 [PATCH] selftests/networking: remove timestamping clean target Anders Roxell
2019-01-31 19:07 ` Anders Roxell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADYN=9JAogKRqz7jwKgFZvEMqJNo8QT2aJVuJ0jqB+Ce_g6J1Q@mail.gmail.com' \
--to=anders.roxell@linaro.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).