From: Anders Roxell <anders.roxell@linaro.org>
To: Zong Li <zongbox@gmail.com>
Cc: shuah@kernel.org, Vincent Legoll <vincent.legoll@gmail.com>,
ast@kernel.org, daniel@iogearbox.net, mcgrof@kernel.org,
davem@davemloft.net, Kees Cook <keescook@chromium.org>,
Fathi Boudra <fathi.boudra@linaro.org>,
netdev@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-kselftest@vger.kernel.org, linux-fsdevel@vger.kernel.org,
zong@andestech.com, greentime@andestech.com
Subject: Re: [PATCH] selftest: fix kselftest-merge depend on 'RUNTIME_TESTING_MENU'
Date: Tue, 27 Feb 2018 23:32:45 +0100 [thread overview]
Message-ID: <CADYN=9JgNRqs5ghv9_UU0MEEKX_kg+L2KXs3c-tXpw1m0dnxDw@mail.gmail.com> (raw)
In-Reply-To: <CA+ZOyajDWFr9dG70uOMoreA=FALoKJCYsFRiUAkZC-a3BuojZg@mail.gmail.com>
On 23 February 2018 at 08:05, Zong Li <zongbox@gmail.com> wrote:
> 2018-02-23 3:57 GMT+08:00 Anders Roxell <anders.roxell@linaro.org>:
>> On 22 February 2018 at 12:53, Zong Li <zongbox@gmail.com> wrote:
>>> Since the 'commit d3deafaa8b5c ("lib/: make RUNTIME_TESTS a menuconfig
>>> to ease disabling it all")', the make kselftest-merge cannot merge the
>>> config dependencies of kselftest to the existing .config file.
>>>
>>> These config dependencies of kselftest need to enable the
>>> 'CONFIG_RUNTIME_TESTING_MENU=y' at the same time.
>>
>> Is this patch needed when patch sha 'f29c79906064 ("lib/Kconfig.debug: enable
>> RUNTIME_TESTING_MENU")' find its way into the kernel ?
>> I think it's in linux-next now.
>
> Thanks. The patch sha 'f29c79906064 ("lib/Kconfig.debug: enable
> RUNTIME_TESTING_MENU")' can resolve the make kselftest-merge
> on default situation, but I think the kselftest-merge should resolve
> the dependencies
> without the prerequisite, it should enable the 'RUNTIME_TESTING_MENU'
> when merging
> the config of some selftests if RUNTIME_TESTING_MENU is not set.
I see your point, but should the be enabled in a common place that
gets included per
default if running kselftest-merge and not in all config fragments?
Cheers,
Anders
next prev parent reply other threads:[~2018-02-27 22:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 11:53 [PATCH] selftest: fix kselftest-merge depend on 'RUNTIME_TESTING_MENU' Zong Li
2018-02-22 19:50 ` Luis R. Rodriguez
2018-02-22 19:57 ` Anders Roxell
2018-02-23 7:05 ` Zong Li
2018-02-27 22:32 ` Anders Roxell [this message]
2018-02-28 9:13 ` Zong Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADYN=9JgNRqs5ghv9_UU0MEEKX_kg+L2KXs3c-tXpw1m0dnxDw@mail.gmail.com' \
--to=anders.roxell@linaro.org \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=fathi.boudra@linaro.org \
--cc=greentime@andestech.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=vincent.legoll@gmail.com \
--cc=zong@andestech.com \
--cc=zongbox@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).