From: Anders Roxell <anders.roxell@linaro.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Vinod <vkoul@kernel.org>, Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dma: ixm-dma: fix warning comparison of distinct pointer types
Date: Tue, 15 Jan 2019 15:14:12 +0100 [thread overview]
Message-ID: <CADYN=9KOqZXiFYvxWED-f_sJS6G-CqY2pPUYohGuP9Pa6VGUZQ@mail.gmail.com> (raw)
In-Reply-To: <CAOMZO5DGxXBCFbLgqeophv_Jw2nO5wiPXJXuth6CPEfSr9f9=w@mail.gmail.com>
On Mon, 14 Jan 2019 at 22:24, Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Anders,
>
> On Thu, Jan 10, 2019 at 9:15 AM Anders Roxell <anders.roxell@linaro.org> wrote:
> >
> > The warning got introduced by commit 930507c18304 ("arm64: add basic
> > Kconfig symbols for i.MX8"). Since it got enabled for arm64. The warning
> > haven't been seen before since size_t was 'unsigned int' when built on
> > arm32.
> >
> > ../drivers/dma/imx-dma.c: In function ‘imxdma_sg_next’:
> > ../include/linux/kernel.h:846:29: warning: comparison of distinct pointer types lacks a cast
> > (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
> > ^~
> > ../include/linux/kernel.h:860:4: note: in expansion of macro ‘__typecheck’
> > (__typecheck(x, y) && __no_side_effects(x, y))
> > ^~~~~~~~~~~
> > ../include/linux/kernel.h:870:24: note: in expansion of macro ‘__safe_cmp’
> > __builtin_choose_expr(__safe_cmp(x, y), \
> > ^~~~~~~~~~
> > ../include/linux/kernel.h:879:19: note: in expansion of macro ‘__careful_cmp’
> > #define min(x, y) __careful_cmp(x, y, <)
> > ^~~~~~~~~~~~~
> > ../drivers/dma/imx-dma.c:288:8: note: in expansion of macro ‘min’
> > now = min(d->len, sg_dma_len(sg));
> > ^~~
> >
> > Rework so that we use min_t and pass in the size_t that returns the
> > minimum of two values, using the specified type.
> >
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>
> There is a typo in the Subject: s/ixm/imx/ and the prefix should be
> dmaengine instead:
>
> dmaengine: imx-dma: fix warning comparison of distinct pointer types
>
> With that fixed:
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
OK, thanks Fabio.
Dan, do you want me to resend the patch with an updated shortlog or will
you do that when you apply the patch?
Cheers,
Anders
next prev parent reply other threads:[~2019-01-15 14:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 11:15 [PATCH] dma: ixm-dma: fix warning comparison of distinct pointer types Anders Roxell
2019-01-13 18:35 ` Olof Johansson
2019-01-14 21:24 ` Fabio Estevam
2019-01-15 14:14 ` Anders Roxell [this message]
2019-01-20 5:46 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADYN=9KOqZXiFYvxWED-f_sJS6G-CqY2pPUYohGuP9Pa6VGUZQ@mail.gmail.com' \
--to=anders.roxell@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).