From: Anders Roxell <anders.roxell@linaro.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Dmitry Vyukov <dvyukov@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2] kernel/trace: fix watchdog soft lockup
Date: Wed, 20 Mar 2019 12:17:29 +0100 [thread overview]
Message-ID: <CADYN=9L=rL98C-4uTeg72KJPMK7M6xXcELz-u=PSqrY=KwaBJA@mail.gmail.com> (raw)
In-Reply-To: <20181130101815.75038642@gandalf.local.home>
On Fri, 30 Nov 2018 at 16:18, Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Fri, 30 Nov 2018 15:56:22 +0100
> Anders Roxell <anders.roxell@linaro.org> wrote:
>
> > When building a allmodconfig kernel for arm64 and boot that in qemu,
> > CONFIG_FTRACE_STARTUP_TEST gets enabled and that takes time so the
> > watchdog expires and prints out a message like this:
> > 'watchdog: BUG: soft lockup - CPU#0 stuck for 22s! [swapper/0:1]'
> > Depending on what the what test gets called from init_trace_selftests()
> > it stays minutes in the loop.
> > Rework so that function cond_resched() gets called in the
> > init_trace_selftests loop.
> >
>
> This looks fine to me. Should it be marked for stable, and pushed into
> this release cycle, or wait till the next merge window?
Steve, I'm sorry for the late reply and no its not urgent.
Maybe it can make it into v5.2 ?
Cheers,
Anders
>
> -- Steve
>
> > Co-developed-by: Arnd Bergmann <arnd@arndb.de>
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > ---
> > kernel/trace/trace.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> > index 5706599ed534..109becbc81ca 100644
> > --- a/kernel/trace/trace.c
> > +++ b/kernel/trace/trace.c
> > @@ -1547,6 +1547,10 @@ static __init int init_trace_selftests(void)
> > pr_info("Running postponed tracer tests:\n");
> >
> > list_for_each_entry_safe(p, n, &postponed_selftests, list) {
> > + /* This loop can take minutes when sanitizers are enabled, so
> > + * lets make sure we allow RCU processing.
> > + */
> > + cond_resched();
> > ret = run_tracer_selftest(p->type);
> > /* If the test fails, then warn and remove from available_tracers */
> > if (ret < 0) {
>
prev parent reply other threads:[~2019-03-20 11:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 14:56 [PATCH v2] kernel/trace: fix watchdog soft lockup Anders Roxell
2018-11-30 15:18 ` Steven Rostedt
2019-03-20 11:17 ` Anders Roxell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADYN=9L=rL98C-4uTeg72KJPMK7M6xXcELz-u=PSqrY=KwaBJA@mail.gmail.com' \
--to=anders.roxell@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).