From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67BCAC47247 for ; Tue, 5 May 2020 11:59:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D50C206A4 for ; Tue, 5 May 2020 11:59:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hHN3cpNo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728727AbgEEL7X (ORCPT ); Tue, 5 May 2020 07:59:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727090AbgEEL7W (ORCPT ); Tue, 5 May 2020 07:59:22 -0400 Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6298FC061A0F for ; Tue, 5 May 2020 04:59:22 -0700 (PDT) Received: by mail-lf1-x141.google.com with SMTP id x73so1128691lfa.2 for ; Tue, 05 May 2020 04:59:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uvyOYLDN9I6G44mzBr+eJp9UfWHxSSZYkeApkR1DRBs=; b=hHN3cpNowtbVxjqPXfJfjcZuJmb+J5Kee+wNPfV9hQkfN6yoyfeyUucbR++axL8aVO fpMlI4YRF0nBgFxj0vf15GhO5Tu6ZjZhlnzuV7hw2ZRQQlbMzyng/Z8bKQscC6Oaufq8 l1GmOUQksiW11jYhrFJ4wBF5dsH0k9uAhQH7d8UQF4PlFwcA3sCFOfkX/xyTMNnoIWOF qytR5uXEloKnzfJ+g5FAPbCMc/nIfqmt+qIm3f1NMUgRG9dwDyRuYHU5O9nE8S85orQx hNBEhK7Z/1qq73yW5LxMcV/YZUA6QH8SQO/N9TvmN4GiDfJHntWV+shP19bozbSAO+Xp rBkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uvyOYLDN9I6G44mzBr+eJp9UfWHxSSZYkeApkR1DRBs=; b=pUKyHAgIst9kw/cFDbE4552dZsX5FRzp88+clmTwetNBSWrVp/0NgWqX2tr7rLiU0u HJbDbHAVFya7KOSRdPdgexTY65GStswx43y1FHFNySKZ1vq/VAE76xVtUY/zDqR+RMKf 9se6RCsVYvou6f1D5EeVtKlVDjUBhP4Hmn4iQAO/4kjTiiCAEh8/Ib5wLZ+WrnlykT33 +dVSmNbr3mrAApaXPmoqf6lzhoHQ8eUqeRZ6NtA/dhAZ5kzqR4nJLocZrAVAEG4NeDqq 2fY573sX2sb7fJG+D6abwwVO5phL9RNkoDinFjPoHYm9sF9eCdnFS0Mq2XO4nRxfwU36 9GIg== X-Gm-Message-State: AGi0PubP8TuFpSGfhrfTFwzNFe0WaETvoVzJxJGEIMcCNw7Q4dJpZwln ScY3ynJEkD9Q5Ae39i/yL6I6lEVFe/lZal7JPL7xbg== X-Google-Smtp-Source: APiQypIOI/I3XWJ7qttW55NOmWj7VnuraK3AIGYXqHuHAPnirsq/4IwWVzOkmHsLKcQv2q+P2ChRK+/WFoZed5VuL3Y= X-Received: by 2002:a05:6512:1109:: with SMTP id l9mr1543834lfg.12.1588679960671; Tue, 05 May 2020 04:59:20 -0700 (PDT) MIME-Version: 1.0 References: <20200501205011.14899-1-grygorii.strashko@ti.com> <20200501205011.14899-4-grygorii.strashko@ti.com> <1bf51157-9fee-1948-f9ff-116799d12731@ti.com> In-Reply-To: From: Anders Roxell Date: Tue, 5 May 2020 13:59:09 +0200 Message-ID: Subject: Re: [PATCH net-next 3/7] net: ethernet: ti: am65-cpsw-nuss: enable packet timestamping support To: Grygorii Strashko Cc: Richard Cochran , Murali Karicheri , "David S. Miller" , Rob Herring , Tero Kristo , Lokesh Vutla , Networking , Sekhar Nori , Linux Kernel Mailing List , devicetree@vger.kernel.org, Linux ARM , Nishanth Menon Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 5 May 2020 at 13:16, Anders Roxell wrote: > > On Tue, 5 May 2020 at 13:05, Grygorii Strashko wrote: > > > > hi Anders, > > Hi Grygorii, Hi again, > > > > > On 05/05/2020 13:17, Anders Roxell wrote: > > > On Fri, 1 May 2020 at 22:50, Grygorii Strashko wrote: > > >> > > >> The MCU CPSW Common Platform Time Sync (CPTS) provides possibility to > > >> timestamp TX PTP packets and all RX packets. > > >> > > >> This enables corresponding support in TI AM65x/J721E MCU CPSW driver. > > >> > > >> Signed-off-by: Grygorii Strashko > > >> --- > > >> drivers/net/ethernet/ti/Kconfig | 1 + > > >> drivers/net/ethernet/ti/am65-cpsw-ethtool.c | 24 ++- > > >> drivers/net/ethernet/ti/am65-cpsw-nuss.c | 172 ++++++++++++++++++++ > > >> drivers/net/ethernet/ti/am65-cpsw-nuss.h | 6 +- > > >> 4 files changed, 201 insertions(+), 2 deletions(-) > > >> > > >> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig > > >> index 1f4e5b6dc686..2c7bd1ccaaec 100644 > > >> --- a/drivers/net/ethernet/ti/Kconfig > > >> +++ b/drivers/net/ethernet/ti/Kconfig > > >> @@ -100,6 +100,7 @@ config TI_K3_AM65_CPSW_NUSS > > >> depends on ARCH_K3 && OF && TI_K3_UDMA_GLUE_LAYER > > >> select TI_DAVINCI_MDIO > > >> imply PHY_TI_GMII_SEL > > >> + imply TI_AM65_CPTS > > > > > > Should this be TI_K3_AM65_CPTS ? instead of 'imply TI_K3_AM65_CPTS' don't you want to do this: 'depends on TI_K3_AM65_CPTS || !TI_K3_AM65_CPTS' Cheers, Anders > > > > > > I did an arm64 allmodconfig build on todays next tag: next-20200505 > > > and got this undefined symbol: > > > > > > aarch64-linux-gnu-ld: drivers/net/ethernet/ti/am65-cpsw-nuss.o: in > > > function `am65_cpsw_init_cpts': > > > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-nuss.c:1685: > > > undefined reference to `am65_cpts_create' > > > aarch64-linux-gnu-ld: > > > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-nuss.c:1685:(.text+0x2e20): > > > relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol > > > `am65_cpts_create' > > > aarch64-linux-gnu-ld: drivers/net/ethernet/ti/am65-cpsw-nuss.o: in > > > function `am65_cpsw_nuss_tx_compl_packets': > > > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-nuss.c:923: > > > undefined reference to `am65_cpts_tx_timestamp' > > > aarch64-linux-gnu-ld: > > > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-nuss.c:923:(.text+0x4cf0): > > > relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol > > > `am65_cpts_tx_timestamp' > > > aarch64-linux-gnu-ld: drivers/net/ethernet/ti/am65-cpsw-nuss.o: in > > > function `am65_cpsw_nuss_ndo_slave_xmit': > > > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-nuss.c:1018: > > > undefined reference to `am65_cpts_prep_tx_timestamp' > > > aarch64-linux-gnu-ld: > > > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-nuss.c:1018:(.text+0x58fc): > > > relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol > > > `am65_cpts_prep_tx_timestamp' > > > aarch64-linux-gnu-ld: drivers/net/ethernet/ti/am65-cpsw-nuss.o: in > > > function `am65_cpsw_nuss_hwtstamp_set': > > > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-nuss.c:1265: > > > undefined reference to `am65_cpts_rx_enable' > > > aarch64-linux-gnu-ld: > > > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-nuss.c:1265:(.text+0x7564): > > > relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol > > > `am65_cpts_rx_enable' > > > aarch64-linux-gnu-ld: drivers/net/ethernet/ti/am65-cpsw-ethtool.o: in > > > function `am65_cpsw_get_ethtool_ts_info': > > > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-ethtool.c:713: > > > undefined reference to `am65_cpts_phc_index' > > > aarch64-linux-gnu-ld: > > > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-ethtool.c:713:(.text+0xbe8): > > > relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol > > > `am65_cpts_phc_index' > > > make[1]: *** [/srv/src/kernel/next/Makefile:1114: vmlinux] Error 1 > > > make[1]: Target 'Image' not remade because of errors. > > > make: *** [Makefile:180: sub-make] Error 2 > > > make: Target 'Image' not remade because of errors. > > > > Sry, I can't reproduce it net-next. > > Oh I forgot to try net-next, sorry. > > > trying next... > > Thank you. > > > What's your config? > > This is the config [1] I used. > > Cheers, > Anders > [1] https://people.linaro.org/~anders.roxell/kernel-next-20200505.config > > > > > -- > > Best regards, > > grygorii