From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932217AbbCIVcS (ORCPT ); Mon, 9 Mar 2015 17:32:18 -0400 Received: from mail-ie0-f175.google.com ([209.85.223.175]:46446 "EHLO mail-ie0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754119AbbCIVbw (ORCPT ); Mon, 9 Mar 2015 17:31:52 -0400 MIME-Version: 1.0 In-Reply-To: <20150309212016.GI5264@atomide.com> References: <20150309205157.GE5140@atomide.com> <20150309211306.GC22341@saruman.tx.rr.com> <20150309212016.GI5264@atomide.com> Date: Mon, 9 Mar 2015 16:31:51 -0500 Message-ID: Subject: Re: [PATCH] phy: Add a driver for dm816x USB PHY From: Bin Liu To: Tony Lindgren Cc: balbi@ti.com, Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-usb , Brian Hutchinson Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 9, 2015 at 4:20 PM, Tony Lindgren wrote: > * Bin Liu [150309 14:17]: >> On Mon, Mar 9, 2015 at 4:13 PM, Felipe Balbi wrote: >> > On Mon, Mar 09, 2015 at 04:11:28PM -0500, Bin Liu wrote: >> >> Hi, >> >> >> >> On Mon, Mar 9, 2015 at 3:51 PM, Tony Lindgren wrote: >> >> > Add a minimal driver for dm816x USB. Otherwise we can just use >> >> > the existing musb_am335x and musb_dsps on dm816x. >> >> >> >> dm816x has the almost identical usbss as that in am335x, we should be >> >> able to adopt musb_am335x and musb_dsps for dm816x, and dm814x too? >> > >> > Tony's using the same musb glue layers, this is just a phy driver, >> > right ? >> >> Can the current am335x phy driver be adopted too? I remember it is >> under drivers/usb/phy/. > > Yes this is just the phy, other than that things work the same. > > I believe this is different from the am335x phy, and more similar to > what we have in old drivers/usb/musb/davinci.c. Chances are dm814x > is same as am335x phy. Alright, I only played the dm814x board a few times, but never with dm816x, and thought dm816x and dm814x usbss are the same and very close to am335x - am335x came out later than dm81xx and has some improvement in usbss. > > But yeah, we really should do a proper phy driver for am335x too > along the same lines. Might even be be able to combine those drivers > with just different compatible values to set the quirks and the > enable/disable functions. Ok, I agreed we can make dm816x working first, then gradually move am335x aligned to the framework. Regards, -Bin. > > Regards, > > Tony