From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756008AbcLBTBW (ORCPT <rfc822;w@1wt.eu>);
        Fri, 2 Dec 2016 14:01:22 -0500
Received: from mail-wm0-f68.google.com ([74.125.82.68]:33030 "EHLO
        mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752096AbcLBTBU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 2 Dec 2016 14:01:20 -0500
MIME-Version: 1.0
In-Reply-To: <CACRpkdbB9AYWiaoLtr6QLZXSsyGZYkDRy2F6VKopHxx+c=FsWg@mail.gmail.com>
References: <1480132046-5406-1-git-send-email-a.mathur@samsung.com>
 <fc667b4b-6d40-db6e-3855-7a181fa97458@kernel.org> <CACRpkdbB9AYWiaoLtr6QLZXSsyGZYkDRy2F6VKopHxx+c=FsWg@mail.gmail.com>
From: Aniroop Mathur <aniroop.mathur@gmail.com>
Date: Sat, 3 Dec 2016 00:31:18 +0530
Message-ID: <CADYu30_epk8BVEjEag+eMqsAzugY69nhh80YO-qiC9-VofQZew@mail.gmail.com>
Subject: Re: [PATCH] IIO: Change msleep to usleep_range for small msecs
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
        Aniroop Mathur <a.mathur@samsung.com>,
        Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald <pmeerw@pmeerw.net>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        s.samuel@samsung.com, r.mahale@samsung.com,
        Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
        Linus Walleij <linus.walleij@stericsson.com>,
        Vlad Dogaru <vlad.dogaru@intel.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 30, 2016 at 5:49 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Sun, Nov 27, 2016 at 11:51 AM, Jonathan Cameron <jic23@kernel.org> wrote:
>> On 26/11/16 03:47, Aniroop Mathur wrote:
>
> [bmp280.c]
>
>>>       /* Wait to make sure we started up properly */
>>> -     mdelay(data->start_up_time);
>>> +     usleep_range(data->start_up_time, data->start_up_time + 100);
>>
>> As this in probe I doubt we really care.  Could just set it longer to shut up the warnings.
>> Still would like some input from say Linus on this...
>
> Hm, I don't think it's a big issue... this works too it just looks overworked.
>
> On the runtime_resume() path we use msleep() instead which I guess is why
> it is not changed in this patch, but they have the same purpose.
>

I did change msleep to usleep_range in runtime_resume() in bmp280.c
as you know resume time is critical indeed.


> Yours,
> Linus Walleij