From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB186C4741F for ; Sun, 27 Sep 2020 15:01:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A06B2389F for ; Sun, 27 Sep 2020 15:01:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sartura-hr.20150623.gappssmtp.com header.i=@sartura-hr.20150623.gappssmtp.com header.b="Hx67KdK+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726350AbgI0PBF (ORCPT ); Sun, 27 Sep 2020 11:01:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726196AbgI0PBF (ORCPT ); Sun, 27 Sep 2020 11:01:05 -0400 Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6712C0613CE for ; Sun, 27 Sep 2020 08:01:04 -0700 (PDT) Received: by mail-io1-xd44.google.com with SMTP id z13so8445630iom.8 for ; Sun, 27 Sep 2020 08:01:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sartura-hr.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6XWqSgpr9w+Cpv2RWf3dg57txkghmrOFhF+JT7YUUFo=; b=Hx67KdK+eLb1KhFlN+brjEytuno5Nb4kE/ImIazivnLcepkU2GnunWk/4nf/JOIgrX xGqa1rFYLOMSxk3VeAOY5ajGOHjOrfT2nUwEUyTkb5gMiaJEzdX1IOfcdLuhwb3jXP4U GMhbH7VJakdCkSHjuT5tLm2BgtFYScLY0+8FcDpX5Tvw77gpS3N+YpYA2IPrHd+VFt7y uo55QNeGd16WRKmS55HxA9spA1abVNxkLvhyS3hZiCEyn0RQDPgaexzalPBjnm+xmcZW MUEtvhz+p6pFf63OgIPX8iulwsRprts2Tl/BzkTj0FIOt6kQSo1/YgAQeb8n9sja6jeK Ag1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6XWqSgpr9w+Cpv2RWf3dg57txkghmrOFhF+JT7YUUFo=; b=eZDZVkJZ2yuyax46NqJMi4rBV3QbLC79qd78xEOvzUAdmASqs6Khuv4NXj8RwiN46k fksNFM4MexVqALhunXLGpPvHNxFl+o2bLMUevyDUSLFfLBzhFq7RGBlfqIxzN4ggq8hw FAuUcIoaAR0+cwsCcjnZ6dUrZSw/TKtiqk9V6WEXKWvC140DZFfaz96jTaRyw8ubvJFn RyHbJgEhErniGc05vBU5QiEG+Vmz/p+qkjuekDdCpYtip7NR6b+6g9SVXaN9IABwwcz8 eG6bPmuQwu9b4A7mN/sGON5+IKm+YcVAX2vBmAWk4U0+AUS2T5sXfCAyWRTHFQarWasd 6LCA== X-Gm-Message-State: AOAM532BkKISug6T+IPOgxy8QsOiDwPZqNwfOoaMFcCkLA647FvNsUPV QZ2BH3qw5aUloHpXxCtScboIZr3L7jz4+3JAv9nB7Q== X-Google-Smtp-Source: ABdhPJyrAZSI73bweKVR53OC+XYNW95pSyhMq69jsjspDDDJJ21Ls4kVbWswaTAl9zIUZNW8EJqsGNTvSlZc3GQv29g= X-Received: by 2002:a02:94c8:: with SMTP id x66mr6028097jah.64.1601218863238; Sun, 27 Sep 2020 08:01:03 -0700 (PDT) MIME-Version: 1.0 References: <20200926135514.26189-1-luka.kovacic@sartura.hr> <20200926135514.26189-8-luka.kovacic@sartura.hr> <20200926195008.6bd84dd3@nic.cz> In-Reply-To: <20200926195008.6bd84dd3@nic.cz> From: Luka Kovacic Date: Sun, 27 Sep 2020 17:01:04 +0200 Message-ID: Subject: Re: [PATCH v2 7/7] arm64: dts: marvell: Add a device tree for the iEi Puzzle-M801 board To: Marek Behun , Andrew Lunn Cc: Linux Kernel Mailing List , linux-hwmon@vger.kernel.org, linux-arm Mailing List , Linux LED Subsystem , Lee Jones , Pavel Machek , Dan Murphy , Rob Herring , Jean Delvare , Guenter Roeck , Jason Cooper , Gregory Clement , Luka Perkov , Robert Marko Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Andrew and Marek, I will break the new patchset up and also add Gregory to the DT conversation. Should I exclude this patch from this patchset or can I just add him to Cc? First six LEDs are used to indicate port status and activity on the SFP+ ports. Certainly, I will change this once the API is solved. There are currently many similar boards with no real solution for the network LED triggers. I'll add the color and correct the function properties for the LEDs. Kind regards, Luka On Sat, Sep 26, 2020 at 7:50 PM Marek Behun wrote: > > On Sat, 26 Sep 2020 15:55:14 +0200 > Luka Kovacic wrote: > > > + leds { > > + compatible = "gpio-leds"; > > + status = "okay"; > > + pinctrl-0 = <&cp0_sfpplus_led_pins &cp1_sfpplus_led_pins>; > > + pinctrl-names = "default"; > > + > > + led0 { > > + function = LED_FUNCTION_STATUS; > > + label = "p2_act"; > > + gpios = <&cp1_gpio1 6 GPIO_ACTIVE_LOW>; > > + }; > > There should be a dash in LED node name, please pass this dts via > dt_binding_check > led-0 { > ... > }; > > Also why not add the `color` property to the LED? This is DTS for a > specific device, right? > `label` is obsolete. The LED subsystem creates a name in form > [device:]color:function > If this LED should blink for activity on port 2 (is this an ethernet > port?), the function should be LED_FUNCTION_LAN and function-enumerator > should be <2> (or function should be LED_FUNCTION_ACTIVITY, depending > on how the LED subsystem goes forward with this, but certainly not > LED_FUNCTION_STATUS), and trigger-sources should be set to point to the > ethernet port. > > Luka, are you willing to change this once we solve this API properly > in LED subsystem? > > > > > + led6 { > > + function = LED_FUNCTION_STATUS; > > + linux,default-trigger = "disk-activity"; > > + label = "front-hdd-led"; > > + gpios = <&cp0_gpio2 22 GPIO_ACTIVE_HIGH>; > > + }; > > led-6. LED_FUNCTION_DISK. `label` deprecated. > > > + leds { > > + compatible = "iei,wt61p803-puzzle-leds"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + led@0 { > > + reg = <0>; > > + color = ; > > + label = "front-power-led"; > > + }; > > Again, `label` is deprecated. Rather use function = > ; > > Marek