From: ChiYuan Huang <u0084500@gmail.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
robh+dt@kernel.org, matthias.bgg@gmail.com,
Guenter Roeck <linux@roeck-us.net>,
cy_huang <cy_huang@richtek.com>,
gene_chen@richtek.com, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] usb typec: mt6360: Add support for mt6360 Type-C driver
Date: Fri, 28 Aug 2020 18:27:26 +0800 [thread overview]
Message-ID: <CADiBU3-S025q10WYzLk+v2K-5V+iTP=zDu4i8srTpHQvRkm0UQ@mail.gmail.com> (raw)
In-Reply-To: <20200828093835.GC174928@kuha.fi.intel.com>
Heikki Krogerus <heikki.krogerus@linux.intel.com> 於 2020年8月28日 週五 下午5:39寫道:
>
> On Thu, Aug 27, 2020 at 10:51:43PM +0800, ChiYuan Huang wrote:
> > Heikki Krogerus <heikki.krogerus@linux.intel.com> 於 2020年8月27日 週四 下午10:00寫道:
> > >
> > > On Thu, Aug 27, 2020 at 07:18:55PM +0800, cy_huang wrote:
> > > > From: ChiYuan Huang <cy_huang@richtek.com>
> > > >
> > > > Mediatek MT6360 is a multi-functional IC that includes USB Type-C.
> > > > It works with Type-C Port Controller Manager to provide USB PD
> > > > and USB Type-C functionalities.
> > > >
> > > > v1 to v2
> > > > 1. Add fix to Prevent the race condition from interrupt and tcpci port
> > > > unregister during module remove.
> > > >
> > > > v2 to v3
> > > > 1. Change comment style for the head of source code.
> > > > 2. No need to print error for platform_get_irq_byname.
> > > > 3. Fix tcpci_register_port check from IS_ERR_OR_NULL to IS_ERR.
> > > > 4. Rename driver/Kconfig/Makefile form mt6360 to mt636x.
> > > > 5. Rename DT binding documents from mt6360 to mt636x.
> > >
> > > You don't place additional changelog here...
> > >
> > > > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> > > > ---
> > >
> > > You put it here, after that '---' marker:
> > > https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format
> > >
> > HI Hekki:
> > after reading the document, I have a little bit confused how to
> > use diffstat for the changelog.
> > Is there any example that make me know to write a clear
> > description for the changelog?
>
> Picking the latest patch from linux-usb ml. with version history:
> https://lore.kernel.org/linux-usb/1598083553-31896-11-git-send-email-chunfeng.yun@mediatek.com/
>
> See how the last tag line "Signed-off-by: Chunfeng Yun..." is followed
> by marker "---", which then is followed by the version history (the
> version history is then also ended with the marker "---", a step that
> I don't think is mandatory, but commonly used and often recommended).
>
> That way that patch version history does not contaminate the actual
> commit message.
>
>
> thanks,
>
Ah, I already send the patch v4, I only add the changelog after the
sign-off --- label, but forget to add --- after changelog ended
Please let me resend the patch v4 to add --- label after the change log eded.
> --
> heikki
next prev parent reply other threads:[~2020-08-28 10:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 11:18 [PATCH v3 1/3] usb typec: mt6360: Add support for mt6360 Type-C driver cy_huang
2020-08-27 11:18 ` [PATCH v3 2/3] usb typec: mt6360: Rename driver/Kconfig/Makefile from mt6360 to mt636x cy_huang
2020-08-27 16:41 ` Guenter Roeck
2020-08-28 5:54 ` ChiYuan Huang
2020-08-27 11:18 ` [PATCH v3 3/3] usb typec: mt6360: Add MT6360 Type-C DT binding documentation cy_huang
2020-08-27 14:00 ` [PATCH v3 1/3] usb typec: mt6360: Add support for mt6360 Type-C driver Heikki Krogerus
2020-08-27 14:51 ` ChiYuan Huang
2020-08-28 9:38 ` Heikki Krogerus
2020-08-28 10:27 ` ChiYuan Huang [this message]
2020-08-28 11:57 ` Heikki Krogerus
2020-08-28 12:10 ` Chunfeng Yun
2020-08-28 14:33 ` ChiYuan Huang
2020-08-28 14:48 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADiBU3-S025q10WYzLk+v2K-5V+iTP=zDu4i8srTpHQvRkm0UQ@mail.gmail.com' \
--to=u0084500@gmail.com \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=gene_chen@richtek.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).