linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: ChiYuan Huang <u0084500@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	lkml <linux-kernel@vger.kernel.org>, 游子馨 <alina_yu@richtek.com>,
	"Sebastian Reichel" <sre@kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	alinayu829@gmail.com, "Rob Herring" <robh+dt@kernel.org>,
	"Linux PM" <linux-pm@vger.kernel.org>,
	cy_huang <cy_huang@richtek.com>
Subject: Re: [PATCH 1/2] dt-bindings: power: supply: Add Richtek RT9471 battery charger
Date: Sat, 13 Aug 2022 00:07:14 +0800	[thread overview]
Message-ID: <CADiBU39-4xdaMO5fOXOZyhC3w0TxdzZyfsFZXbcFw3=i+6UOMQ@mail.gmail.com> (raw)
In-Reply-To: <1660317233.429908.168977.nullmailer@robh.at.kernel.org>

Rob Herring <robh@kernel.org> 於 2022年8月12日 週五 晚上11:13寫道:
>
> On Thu, 11 Aug 2022 21:41:57 +0800, cy_huang wrote:
> > From: ChiYuan Huang <cy_huang@richtek.com>
> >
> > Add bindings for the Richtek RT9471 I2C controlled battery charger.
> >
> > Co-developed-by: Alina Yu <alina_yu@richtek.com>
> > Signed-off-by: Alina Yu <alina_yu@richtek.com>
> > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> > ---
> >  .../bindings/power/supply/richtek,rt9471.yaml      | 78 ++++++++++++++++++++++
> >  1 file changed, 78 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/power/supply/richtek,rt9471.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/power/supply/richtek,rt9471.example.dtb: charger@53: usb-otg-vbus-regulator: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
>         From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/power/supply/richtek,rt9471.yaml
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/patch/
>
Thanks, after I add 'DT_CHECKER_FLAGS=-m', it also can be found for this error.

This is typo, not 'regulator-compatible', it's 'regulator-name'.

Will be fixed in next revision.
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>

  reply	other threads:[~2022-08-12 16:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-11 13:41 [PATCH 0/2] Add Richtek RT9471 3A battery charger support cy_huang
2022-08-11 13:41 ` [PATCH 1/2] dt-bindings: power: supply: Add Richtek RT9471 battery charger cy_huang
2022-08-11 14:12   ` Krzysztof Kozlowski
2022-08-12  1:32     ` ChiYuan Huang
2022-08-12  6:54       ` Krzysztof Kozlowski
2022-08-12 15:57         ` ChiYuan Huang
2022-08-12 16:05           ` ChiYuan Huang
2022-08-12 18:53             ` Krzysztof Kozlowski
2022-08-13 14:52               ` ChiYuan Huang
2022-08-16  7:27                 ` Krzysztof Kozlowski
2022-08-12 15:13   ` Rob Herring
2022-08-12 16:07     ` ChiYuan Huang [this message]
2022-08-11 13:41 ` [PATCH 2/2] power: supply: rt9471: Add Richtek RT9471 charger driver cy_huang
2022-08-15  5:53   ` Matti Vaittinen
2022-08-15  6:10     ` ChiYuan Huang
2022-08-15  7:24       ` Matti Vaittinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADiBU39-4xdaMO5fOXOZyhC3w0TxdzZyfsFZXbcFw3=i+6UOMQ@mail.gmail.com' \
    --to=u0084500@gmail.com \
    --cc=alina_yu@richtek.com \
    --cc=alinayu829@gmail.com \
    --cc=cy_huang@richtek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).