linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: ChiYuan Huang <u0084500@gmail.com>
To: Mark Brown <broonie@kernel.org>, lgirdwood@gmail.com, robh+dt@kernel.org
Cc: linux-kernel@vger.kernel.org, cy_huang <cy_huang@richtek.com>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v1 2/2] regulator: rtmv20: Add DT-binding document for Richtek RTMV20
Date: Fri, 25 Sep 2020 22:06:57 +0800	[thread overview]
Message-ID: <CADiBU39yO=HYm9G_ftE=MnMjOW5DQjVS4E=HYkhU6ucOJ7yyqQ@mail.gmail.com> (raw)
In-Reply-To: <CADiBU39ShyHNT=NiWz2Y81+wLMJjDqD6aZ0mgzVSxp_rzLZSFQ@mail.gmail.com>

Re-add into the mail loop list.

ChiYuan Huang <u0084500@gmail.com> 於 2020年9月25日 週五 下午12:09寫道：
>
> Mark Brown <broonie@kernel.org> 於 2020年9月25日 週五 上午12:24寫道：
> >
> > On Thu, Sep 24, 2020 at 11:04:51PM +0800, cy_huang wrote:
> >
> > > +  enable-gpio:
> > > +    description: A connection of the 'enable' gpio line.
> > > +    maxItems: 1
> >
> > -gpios.  GPIO properties should always be plural even if there's only
> > one GPIO.
> >
> > > +  ld_pulse_delay:
> >
> > Properties should use - not _ and for all the properties specifying
> > things like times you should have units so...
> >
> > > +    description: |
> > > +      load current pulse delay in microsecond after strobe pin pulse high.
> > > +    $ref: "/schemas/types.yaml#/definitions/uint32"
> >
> > ...add -us here.
> >
> Ack
> > > +  fsin_enable:
> > > +    description: Fsin function enable control.
> > > +    $ref: "/schemas/types.yaml#/definitions/uint32"
> > > +    minimum: 0
> > > +    maximum: 1
> > > +    default: 0
> >
> > This looks like it should be a boolean property not a number.  The same
> > is true for most if not all of the other properties with min/max of 0/1.
> Ok, just change the property as boolean type.

  parent reply	other threads:[~2020-09-25 14:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-24 15:04 [PATCH v1 1/2] regulator: rtmv20: Adds support for Richtek RTMV20 load switch regulator cy_huang
2020-09-24 15:04 ` [PATCH v1 2/2] regulator: rtmv20: Add DT-binding document for Richtek RTMV20 cy_huang
2020-09-24 16:23   ` Mark Brown
     [not found]     ` <CADiBU39ShyHNT=NiWz2Y81+wLMJjDqD6aZ0mgzVSxp_rzLZSFQ@mail.gmail.com>
2020-09-25 14:06       ` ChiYuan Huang [this message]
2020-09-24 16:11 ` [PATCH v1 1/2] regulator: rtmv20: Adds support for Richtek RTMV20 load switch regulator Mark Brown
     [not found]   ` <CADiBU3_b69g9vZf-J8p2_m5xDjn24XaUHn88foBsQ4MpBN829g@mail.gmail.com>
     [not found]     ` <20200925113224.GB4841@sirena.org.uk>
2020-09-25 14:05       ` ChiYuan Huang
2020-09-25  6:18 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADiBU39yO=HYm9G_ftE=MnMjOW5DQjVS4E=HYkhU6ucOJ7yyqQ@mail.gmail.com' \
    --to=u0084500@gmail.com \
    --cc=broonie@kernel.org \
    --cc=cy_huang@richtek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).