Re: [PATCH v1 2/2] mfd: rt4505: Adds DT binding document for Richtek RT4831 MFD core

From: ChiYuan Huang <u0084500@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, cy_huang <cy_huang@richtek.com>,
	lkml <linux-kernel@vger.kernel.org>,
	Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH v1 2/2] mfd: rt4505: Adds DT binding document for Richtek RT4831 MFD core
Date: Tue, 3 Nov 2020 13:48:40 +0800	[thread overview]
Message-ID: <CADiBU3_T8gRoU7S3rTyW259Gk7AArp_b1qcEhuXrK1QLz5ussw@mail.gmail.com> (raw)
In-Reply-To: <CAL_Jsq+_=OU6X2UynEoV24gycs+c3rQ7j6CJ4euMvnSd8bTufA@mail.gmail.com>

Rob Herring <robh@kernel.org> 於 2020年11月3日 週二 上午9:58寫道：
>
> On Mon, Nov 2, 2020 at 7:14 PM ChiYuan Huang <u0084500@gmail.com> wrote:
> >
> > Rob Herring <robh@kernel.org> 於 2020年11月3日 週二 上午1:21寫道：
> > >
> > > On Mon, 02 Nov 2020 11:13:23 +0800, cy_huang wrote:
> > > > From: ChiYuan Huang <cy_huang@richtek.com>
> > > >
> > > > Adds DT binding document for Richtek RT4831 MFD core.
> > > >
> > > > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> > > > ---
> > > >  .../devicetree/bindings/mfd/richtek,rt4831.yaml    | 89 ++++++++++++++++++++++
> > > >  include/dt-bindings/leds/rt4831-backlight.h        | 23 ++++++
> > > >  2 files changed, 112 insertions(+)
> > > >  create mode 100644 Documentation/devicetree/bindings/mfd/richtek,rt4831.yaml
> > > >  create mode 100644 include/dt-bindings/leds/rt4831-backlight.h
> > > >
> > >
> > >
> > > My bot found errors running 'make dt_binding_check' on your patch:
> > >
> > > yamllint warnings/errors:
> > >
> > > dtschema/dtc warnings/errors:
> > > Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.8/dist-packages/dtschema/schemas/regulator/richtek,rt4831-regulator.yaml'
> > > xargs: dt-doc-validate: exited with status 255; aborting
> > > make[1]: *** [Documentation/devicetree/bindings/Makefile:59: Documentation/devicetree/bindings/processed-schema-examples.json] Error 124
> > > make: *** [Makefile:1364: dt_binding_check] Error 2
> > >
> > >
> > > See https://patchwork.ozlabs.org/patch/1391911
> > >
> > > The base for the patch is generally the last rc1. Any dependencies
> > > should be noted.
> > >
> > > If you already ran 'make dt_binding_check' and didn't see the above
> > > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > > date:
> > >
> > > pip3 install dtschema --upgrade
> > >
> > > Please check and re-submit.
> > >
> > Sorry, I have one question.
> > If the richtek,rt4831.yaml is depend upon the other yaml, do I need to
> > merge it all into one patch?
> > Currently, my submitting order is mfd, backlight, and regulator.
> > Each part divided into two patches (one for source code, another for
> > dt_binding_document)
>
> Doesn't have to be 1 patch, but should be one series with MFD coming
> last as it references the others. Example goes in the MFD binding. I
> need to see a complete picture for what the device is to effectively
> review the binding.
>
Got it. Next, I'll add the regulator and backlight dt-binding into the
series patch.
And add the description into mfd core dt-binding like as below.

This patch depends on
    "backlight: rt4831: Adds DT binding document for Richtek RT4831
backlight module".
    "regulator: rt4831: Adds DT binding document for Richtek RT4831 DSV module".


> Rob