From: ChiYuan Huang <u0084500@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: krzysztof.kozlowski+dt@linaro.org, broonie@kernel.org,
lgirdwood@gmail.com, cy_huang@richtek.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: regulator: Add bindings for Richtek RT6190 regulator
Date: Tue, 25 Oct 2022 08:30:40 +0800 [thread overview]
Message-ID: <CADiBU3_WUeyYdnmnG0Ff2pH+b3u1zOtP1z44LcA53Ba5c9nrEw@mail.gmail.com> (raw)
In-Reply-To: <20221024164251.GA1890861-robh@kernel.org>
Rob Herring <robh@kernel.org> 於 2022年10月25日 週二 凌晨12:42寫道:
>
> On Fri, Oct 21, 2022 at 10:40:58AM +0800, cy_huang wrote:
> > From: ChiYuan Huang <cy_huang@richtek.com>
> >
> > Add devicetree binding for Richtek RT6190 4-Switch buckboost controller.
> >
> > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> > ---
> > Since v2:
> > - Rename binding filename to 'richtek,rt6190.yaml'
> >
> > ---
> > .../bindings/regulator/richtek,rt6190.yaml | 77 ++++++++++++++++++++++
> > 1 file changed, 77 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/regulator/richtek,rt6190.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/regulator/richtek,rt6190.yaml b/Documentation/devicetree/bindings/regulator/richtek,rt6190.yaml
> > new file mode 100644
> > index 00000000..dced404
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/regulator/richtek,rt6190.yaml
> > @@ -0,0 +1,77 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/regulator/richtek,rt6190.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Richtek RT6190 4-Switch BuckBoost controller
> > +
> > +maintainers:
> > + - ChiYuan Huang <cy_huang@richtek.com>
> > +
> > +description: |
> > + The RT6190 is 4-Switch BuckBoost controller designed for converting input
> > + voltage to output voltage that can be equal to, higher or lower than input
> > + voltage. It operates with wide input voltage range from 4.5V to 36V, and
> > + the output voltage can be set from 3V to 36V by external FB pin. It's commonly
> > + used for the application like as BuckBoost bus upply, docking station and USB
>
> typo: upply
>
> > + power delivery product.
> > +
> > + Datasheet is available at
> > + https://www.richtek.com/assets/product_file/RT6190/DS6190-02.pdf
> > +
> > +allOf:
> > + - $ref: regulator.yaml#
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - richtek,rt6190
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + enable-gpios: true
>
> maxItems: 1
>
It's coming from gpio-consumer-common.yaml.
If so, does it still need to declare the 'maxItems'?
> > +
> > + wakeup-source: true
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + regulator-allowed-modes:
> > + description: |
> > + buck allowed operating mode
> > + 0: PSM mode (light load Power Saving Mode)
> > + 1: FCCM mode (Forced-CCM mode)
>
> maxItems: 2
>
> > + items:
> > + enum: [0, 1]
> > +
> > +required:
> > + - compatible
> > + - reg
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/gpio/gpio.h>
> > + #include <dt-bindings/interrupt-controller/irq.h>
> > +
> > + i2c {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + regulator@2c {
> > + compatible = "richtek,rt6190";
> > + reg = <0x2c>;
> > + wakeup-source;
> > + interrupts-extended = <&gpio26 0 IRQ_TYPE_LEVEL_LOW>;
> > + enable-gpios = <&gpio26 1 GPIO_ACTIVE_HIGH>;
> > + regulator-name = "richtek,rt6190-buckboost";
> > + regulator-min-microvolt = <3000000>;
> > + regulator-max-microvolt = <32000000>;
> > + regulator-min-microamp = <306000>;
> > + regulator-max-microamp = <12114000>;
> > + regulator-allowed-modes = <0 1>;
> > + };
> > + };
> > --
> > 2.7.4
> >
> >
next prev parent reply other threads:[~2022-10-25 1:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 2:40 [PATCH v2 0/2] Add support for Richtek RT6190 36V 4-wwtich regulator cy_huang
2022-10-21 2:40 ` [PATCH v2 1/2] dt-bindings: regulator: Add bindings for Richtek RT6190 regulator cy_huang
2022-10-24 16:42 ` Rob Herring
2022-10-25 0:30 ` ChiYuan Huang [this message]
2022-10-21 2:40 ` [PATCH v2 2/2] regulator: rt6190: Add support " cy_huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADiBU3_WUeyYdnmnG0Ff2pH+b3u1zOtP1z44LcA53Ba5c9nrEw@mail.gmail.com \
--to=u0084500@gmail.com \
--cc=broonie@kernel.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).