From: Chen Yu <yu.chen.surf@gmail.com>
To: Len Brown <lenb@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Pavel Machek <pavel@ucw.cz>, Andy Lutomirski <luto@kernel.org>,
Borislav Petkov <bp@suse.de>, George Spelvin <linux@horizon.com>,
"Kaszewski, Marcin" <marcin.kaszewski@intel.com>,
Matthew Garrett <mjg59@srcf.ucam.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Chen Yu <yu.c.chen@intel.com>
Subject: Re: [PATCH][v7] x86, suspend: Save/restore extra MSR registers for suspend
Date: Wed, 25 May 2016 13:02:30 +0800 [thread overview]
Message-ID: <CADjb_WR+ZtBf4x=JkdGhfbBNDGL=eskQp8-FADCSAzHkDLPd8w@mail.gmail.com> (raw)
In-Reply-To: <CAJvTdKn9XyutRAk4Hf5tarQVkCQ4QQL3wtM5RHYfsMg8P3mhnA@mail.gmail.com>
Hi Len,
On Wed, May 25, 2016 at 12:09 AM, Len Brown <lenb@kernel.org> wrote:
> +mjg59, who may be seeing this issue on a skylake laptop
>
> Chen-yu,
>
> Great debugging, but I think there is a more general fix possible than
> this DMI quirk.
>
> I agree that in this example, a grantley server, it seems the BIOS is
> erroneously
> returning a bogus value of MSR_IA32_THERM_CONTROL on resume from S3.
>
> But another scenario is also possible. Consider a laptop that is resuming HOT
> and the BIOS correctly enables throttling. If this code were invoked, it would
> restore the COLD setting.
>
> Instead, it seems to me that the ACPI processor driver should upon .resume
> check if throttling should be enabled or not, and proceed accordingly.
> That would always do the "right thing", and would not need a DMI list.
> Does that make sense?
I agree, to let the related drivers customize their restoring process
would be more robust,
and we can not only take care of boot CPU but also nonboot CPUs in this way.
I think we can add something like acpi_processor_reevaluate_tstate in the resume
hook,I'll make a double check.
thanks,
Yu
next prev parent reply other threads:[~2016-05-25 5:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 17:03 [PATCH][v7] x86, suspend: Save/restore extra MSR registers for suspend Chen Yu
2015-11-26 9:09 ` Ingo Molnar
2015-11-26 15:34 ` Chen, Yu C
2016-05-24 16:09 ` Len Brown
2016-05-25 5:02 ` Chen Yu [this message]
2015-11-27 7:42 ` [tip:x86/platform] x86/pm: Introduce quirk framework to save/ restore extra MSR registers around suspend/resume tip-bot for Chen Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADjb_WR+ZtBf4x=JkdGhfbBNDGL=eskQp8-FADCSAzHkDLPd8w@mail.gmail.com' \
--to=yu.chen.surf@gmail.com \
--cc=bp@suse.de \
--cc=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@horizon.com \
--cc=luto@kernel.org \
--cc=marcin.kaszewski@intel.com \
--cc=mingo@kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).